Skip to content

Commit 408c55c

Browse files
committed
Add in threading considerations for the callback test
1 parent e28d475 commit 408c55c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

analytics/integration_test/src/integration_test.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,13 @@ TEST_F(FirebaseAnalyticsTest, TestSetProperties) {
244244

245245
#if defined(_WIN32)
246246
TEST_F(FirebaseAnalyticsTest, TestSetLogCallback) {
247+
std::promise<void> finishedPromise;
248+
std::future<void> finished Future = readyPromise.get_future();
247249
bool log_callback_called = false;
248250
firebase::analytics::SetLogCallback(
249251
[&](firebase::LogLevel log_level, const char* message) {
250252
log_callback_called = true;
253+
finishedPromise.set_value();
251254
});
252255
// Log an event with an invalid parameter to trigger a log message.
253256
const firebase::analytics::Parameter kInvalidParameters[] = {
@@ -256,6 +259,7 @@ TEST_F(FirebaseAnalyticsTest, TestSetLogCallback) {
256259
firebase::analytics::LogEvent(
257260
"invalid_event", kInvalidParameters,
258261
sizeof(kInvalidParameters) / sizeof(kInvalidParameters[0]));
262+
readyPromise.set_value();
259263
EXPECT_TRUE(log_callback_called);
260264
firebase::analytics::SetLogCallback(nullptr);
261265
}

0 commit comments

Comments
 (0)