Skip to content

Commit 64384db

Browse files
committed
Fix up the formatting and the enum in tc
1 parent ecd7e83 commit 64384db

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

analytics/integration_test/src/integration_test.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,11 +242,11 @@ TEST_F(FirebaseAnalyticsTest, TestSetProperties) {
242242
InitiateOnDeviceConversionMeasurementWithHashedPhoneNumber(hashed_phone);
243243
}
244244

245-
#if defined(_WIN32)
245+
// #if defined(_WIN32)
246246
TEST_F(FirebaseAnalyticsTest, TestSetLogCallback) {
247247
bool log_callback_called = false;
248248
firebase::analytics::SetLogCallback(
249-
[&](firebase::analytics::LogLevel log_level, const char* message) {
249+
[&](firebase::LogLevel log_level, const char* message) {
250250
log_callback_called = true;
251251
});
252252
// Log an event with an invalid parameter to trigger a log message.
@@ -259,7 +259,7 @@ TEST_F(FirebaseAnalyticsTest, TestSetLogCallback) {
259259
EXPECT_TRUE(log_callback_called);
260260
firebase::analytics::SetLogCallback(nullptr);
261261
}
262-
#endif // defined(_WIN32)
262+
// #endif // defined(_WIN32)
263263

264264
TEST_F(FirebaseAnalyticsTest, TestLogEvents) {
265265
// Log an event with no parameters.

analytics/src/analytics_desktop.cc

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -399,20 +399,20 @@ LogLevel ConvertAnalyticsLogLevelToFirebaseLogLevel(
399399
switch (log_level) {
400400
case kDebug:
401401
return kLogLevelDebug;
402-
case kInfo:
403-
return kLogLevelInfo;
404-
case kWarning:
405-
return kLogLevelWarning;
406-
case kError:
407-
return kLogLevelError;
408-
default:
409-
return kLogLevelInfo;
402+
case kInfo:
403+
return kLogLevelInfo;
404+
case kWarning:
405+
return kLogLevelWarning;
406+
case kError:
407+
return kLogLevelError;
408+
default:
409+
return kLogLevelInfo;
410410
}
411411
}
412412

413413
// C-style callback that will be passed to the Google Analytics C API.
414414
static void GoogleAnalyticsWraperLogCallback(GoogleAnalytics_LogLevel log_level,
415-
const char* message) {
415+
const char* message) {
416416
if (g_log_callback) {
417417
LogLevel firebase_log_level =
418418
ConvertAnalyticsLogLevelToFirebaseLogLevel(log_level);

analytics/src/include/firebase/analytics.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
#include <vector>
2626

2727
#include "firebase/app.h"
28-
#include "firebase/log.h"
2928
#include "firebase/future.h"
3029
#include "firebase/internal/common.h"
30+
#include "firebase/log.h"
3131
#include "firebase/variant.h"
3232

3333
#if !defined(DOXYGEN) && !defined(SWIG)
@@ -615,7 +615,7 @@ void ResetAnalyticsData();
615615
///
616616
/// @param[in] log_level The log level of the message.
617617
/// @param[in] message The message logged by the SDK.
618-
using LogCallback = std::function<void(LogLevel, const char*)>;
618+
using LogCallback = std::function<void(LogLevel, const char*)>;
619619

620620
/// @brief Allows the passing of a callback to be used when the SDK logs any
621621
/// messages regarding its behaviour. The callback must be thread-safe.

app/src/util_android.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ bool LookupFieldIds(JNIEnv* env, jclass clazz,
191191

192192
// Used to populate an array of MethodNameSignature.
193193
#define METHOD_NAME_SIGNATURE_5(id, name, signature, method_type, optional) \
194-
{ name, signature, method_type, optional }
194+
{name, signature, method_type, optional}
195195
#define METHOD_NAME_SIGNATURE_4(id, name, signature, method_type) \
196196
METHOD_NAME_SIGNATURE_5( \
197197
id, name, signature, method_type, \

0 commit comments

Comments
 (0)