Add & update unit tests

Author: ashish-kothari

packages/remote-config/test/client/rest_client.test.ts

@@ -114,7 +114,7 @@ describe('RestClient', () => {
       expect(fetchStub).to.be.calledWith(
         sinon.match.string,
         sinon.match({
-          body: '{"sdk_version":"sdk-version","app_instance_id":"fis-id","app_instance_id_token":"fis-token","app_id":"app-id","language_code":"en-US"}'
+          body: '{"sdk_version":"sdk-version","app_instance_id":"fis-id","app_instance_id_token":"fis-token","app_id":"app-id","language_code":"en-GB"}'
         })
       );
     });

packages/remote-config/test/remote_config.test.ts

@@ -42,7 +42,8 @@ import {
   getString,
   getValue,
   setLogLevel,
-  fetchConfig
+  fetchConfig,
+  setCustomSignals
 } from '../src/api';
 import * as api from '../src/api';
 import { fetchAndActivate } from '../src';
@@ -93,6 +94,20 @@ describe('RemoteConfig', () => {
     loggerLogLevelSpy.restore();
   });
 
+  describe('setCustomSignals', () => {
+
+    beforeEach(() => {
+      storageCache.setCustomSignals = sinon.stub();
+      storage.setCustomSignals = sinon.stub();
+    });
+
+    it('call storage API to store signals', async () => {
+      await setCustomSignals(rc, { key: 'value' });
+
+      expect(storageCache.setCustomSignals).to.have.been.calledWith({ key: 'value' });
+    });
+  });
+
   // Adapts getUserLanguage tests from packages/auth/test/utils_test.js for TypeScript.
   describe('setLogLevel', () => {
     it('proxies to the FirebaseLogger instance', () => {
@@ -449,6 +464,7 @@ describe('RemoteConfig', () => {
         .stub()
         .returns(Promise.resolve({ status: 200 } as FetchResponse));
       storageCache.setLastFetchStatus = sinon.stub();
+      storageCache.getCustomSignals = sinon.stub();
       timeoutStub = sinon.stub(window, 'setTimeout');
     });
 
@@ -517,5 +533,11 @@ describe('RemoteConfig', () => {
         'failure'
       );
     });
+
+    it('sends custom signals', async () => {
+      await fetchConfig(rc);
+
+      expect(storageCache.getCustomSignals).to.have.been.called;
+    });
   });
 });

packages/remote-config/test/storage/storage.test.ts

@@ -117,4 +117,27 @@ describe('Storage', () => {
 
     expect(actualMetadata).to.be.undefined;
   });
+
+  it('sets and gets custom signals', async () => {
+    const customSignals = { key: 'value', key1: 'value1'};
+
+    await storage.setCustomSignals(customSignals);
+
+    const storedCustomSignals = await storage.getCustomSignals();
+
+    expect(storedCustomSignals).to.deep.eq(customSignals);
+  });
+
+  it('upserts custom signals when key is present in storage', async () => {
+    const customSignals = { key: 'value', key1: 'value1'};
+    const updatedSignals = { key: 'value', key1: 'value2'};
+
+    await storage.setCustomSignals(customSignals);
+
+    await storage.setCustomSignals({ key1: 'value2'});
+
+    const storedCustomSignals = await storage.getCustomSignals();
+
+    expect(storedCustomSignals).to.deep.eq(updatedSignals);
+  });
 });

packages/remote-config/test/storage/storage_cache.test.ts

@@ -37,6 +37,7 @@ describe('StorageCache', () => {
       const status = 'success';
       const lastSuccessfulFetchTimestampMillis = 123;
       const activeConfig = { key: 'value' };
+      const customSignals = { 'key': 'value' };
 
       storage.getLastFetchStatus = sinon
         .stub()
@@ -47,12 +48,16 @@ describe('StorageCache', () => {
       storage.getActiveConfig = sinon
         .stub()
         .returns(Promise.resolve(activeConfig));
+      storage.getCustomSignals = sinon
+        .stub()
+        .returns(Promise.resolve(customSignals));
 
       await storageCache.loadFromStorage();
 
       expect(storage.getLastFetchStatus).to.have.been.called;
       expect(storage.getLastSuccessfulFetchTimestampMillis).to.have.been.called;
       expect(storage.getActiveConfig).to.have.been.called;
+      expect(storage.getCustomSignals).to.have.been.called;
 
       expect(storageCache.getLastFetchStatus()).to.eq(status);
       expect(storageCache.getLastSuccessfulFetchTimestampMillis()).to.deep.eq(
@@ -81,4 +86,24 @@ describe('StorageCache', () => {
       expect(storage.setActiveConfig).to.have.been.calledWith(activeConfig);
     });
   });
+
+  describe('setCustomSignals', () => {
+    const customSignals = { key: 'value' };
+
+    beforeEach(() => {
+      storage.setCustomSignals = sinon.stub().returns(Promise.resolve());
+    });
+
+    it('writes to memory cache', async () => {
+      await storageCache.setCustomSignals(customSignals);
+
+      expect(storageCache.getCustomSignals()).to.deep.eq(customSignals);
+    });
+
+    it('writes to persistent storage', async () => {
+      await storageCache.setCustomSignals(customSignals);
+
+      expect(storage.setCustomSignals).to.have.been.calledWith(customSignals);
+    });
+  });
 });