Export all public API types and hide internals. This allows the API report steps of the build to complete

Author: MarkDuckworth

packages/firestore/lite/pipelines/pipelines.ts

@@ -194,3 +194,5 @@ export {
   AggregateFunction,
   TimeGranularity
 } from '../../src/lite-api/expressions';
+
+export { Stage } from '../../src/lite-api/stage';

packages/firestore/pipelines/pipelines.ts

@@ -47,7 +47,9 @@ export type {
   SnapshotMetadata,
   Bytes,
   SnapshotListenOptions,
-  Unsubscribe
+  Unsubscribe,
+  DocumentChangeType,
+  ListenSource
 } from '../src/api';
 
 export * from '../src/api_pipelines';

packages/firestore/src/api_pipelines.ts

@@ -25,17 +25,21 @@ export {
   pipelineResultEqual
 } from './lite-api/pipeline-result';
 
-export { RealtimePipelineSnapshot } from './api/snapshot';
+export { RealtimePipelineSnapshot, ResultChange } from './api/snapshot';
 
 export { Pipeline } from './api/pipeline';
 
+export { Stage } from './lite-api/stage';
+
 export { RealtimePipeline } from './api/realtime_pipeline';
 
 // Rename here because we want the exported name to be onSnapshot
 // internally the name has to be onPipelineSnapshot to avoid
 // name collisions.
 import { onPipelineSnapshot as onSnapshot } from './api/reference_impl';
 
+export { PipelineListenOptions } from './api/reference_impl';
+
 export { execute } from './api/pipeline_impl';
 
 export { PipelineExecuteOptions } from './lite-api/pipeline_options';

packages/firestore/src/core/expressions.ts

@@ -317,7 +317,7 @@ export class CoreField implements EvaluableExpr {
       });
     }
     // Return 'UNSET' if the field doesn't exist, otherwise the Value.
-    const result = input.data.field(this.expr.fieldPath);
+    const result = input.data.field(this.expr._fieldPath);
 
     function getServerTimestampValue(
       context: EvaluationContext,

packages/firestore/src/lite-api/expressions.ts

@@ -2581,14 +2581,14 @@ export class Field extends Expression implements Selectable {
    * @private
    */
   constructor(
-    readonly fieldPath: InternalFieldPath,
+    readonly _fieldPath: InternalFieldPath,
     readonly _methodName: string | undefined
   ) {
     super();
   }
 
   get fieldName(): string {
-    return this.fieldPath.canonicalString();
+    return this._fieldPath.canonicalString();
   }
 
   get alias(): string {
@@ -2605,7 +2605,7 @@ export class Field extends Expression implements Selectable {
    */
   _toProto(serializer: JsonProtoSerializer): ProtoValue {
     return {
-      fieldReferenceValue: this.fieldPath.canonicalString()
+      fieldReferenceValue: this._fieldPath.canonicalString()
     };
   }
 

packages/firestore/src/lite-api/pipeline-result.ts

@@ -105,6 +105,9 @@ export class PipelineResult {
   private readonly _createTime: Timestamp | undefined;
   private readonly _updateTime: Timestamp | undefined;
 
+  readonly _metadata: SnapshotMetadata | undefined;
+  readonly _listenOptions: ListenOptions | undefined;
+
   /**
    * @internal
    * @private
@@ -128,21 +131,25 @@ export class PipelineResult {
    * this document.
    * @param createTime The time when the document was created if the result is a document, undefined otherwise.
    * @param updateTime The time when the document was last updated if the result is a document, undefined otherwise.
+   * @param metadata
+   * @param listenOptions
    */
   constructor(
     userDataWriter: AbstractUserDataWriter,
     ref?: DocumentReference,
     fields?: ObjectValue,
     createTime?: Timestamp,
     updateTime?: Timestamp,
-    readonly metadata?: SnapshotMetadata,
-    readonly listenOptions?: ListenOptions
+    metadata?: SnapshotMetadata,
+    listenOptions?: ListenOptions
   ) {
     this._ref = ref;
     this._userDataWriter = userDataWriter;
     this._createTime = createTime;
     this._updateTime = updateTime;
     this._fields = fields ?? ObjectValue.empty();
+    this._metadata = metadata;
+    this._listenOptions = listenOptions;
   }
 
   /**
@@ -234,7 +241,7 @@ export class PipelineResult {
   data(): DocumentData {
     return this._userDataWriter.convertValue(
       this._fields.value,
-      this.listenOptions?.serverTimestampBehavior
+      this._listenOptions?.serverTimestampBehavior
     ) as DocumentData;
   }
 
@@ -274,7 +281,7 @@ export class PipelineResult {
     if (value !== null) {
       return this._userDataWriter.convertValue(
         value,
-        this.listenOptions?.serverTimestampBehavior
+        this._listenOptions?.serverTimestampBehavior
       );
     }
   }