Skip to content

Commit 91f8bbb

Browse files
committed
Address pr feedback
1 parent 9e455d8 commit 91f8bbb

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

packages/telemetry/src/register.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@ import { name, version } from '../package.json';
2222
import { TelemetryService } from './service';
2323
import { createLoggerProvider } from './logging/logger-provider';
2424
import { AppCheckProvider } from './logging/appcheck-provider';
25-
// This needs to be in the same file that calls `getProvider()` on the component
26-
// or it will get tree-shaken out.
27-
import '@firebase/installations';
2825
import { InstallationIdProvider } from './logging/installation-id-provider';
2926

27+
// We only import types from this package elsewhere in the `telemetry` package, so this
28+
// explicit import is needed here to prevent this module from being tree-shaken out.
29+
import '@firebase/installations';
30+
3031
export function registerTelemetry(): void {
3132
_registerComponent(
3233
new Component(

0 commit comments

Comments
 (0)