Partially implement javascript source map upload command #9447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaroneee
approved these changes
Nov 10, 2025
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
joehan
reviewed
Nov 19, 2025
joehan
approved these changes
Nov 19, 2025
Contributor
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
This like 90% looks good to me - only blocking bit is putting a depth cap on the recursive read (we just got burned by something similar yesterday, so I'm feeling extra cautious here). Everything else is a nice to have and can be done in a follow up
andrewbrook
force-pushed
the
telemetry1
branch
from
39cba75 to
48e1c4f
Compare
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new, partially implemented command for uploading javascript mapping files. The command takes the user-supplied mapping file path, or a path to a directory, and uploads all available *.js.map files to the customer's Google Cloud Storage bucket. If the bucket does not exist yet, it is created.
The next steps for this command are to:
Scenarios Tested
Sample Commands
firebase crashlytics:sourcemap:upload path/to/build/mapping.js.map --app
firebase crashlytics:sourcemap:upload .next --app