Improve environment slug handling

[peterbbeu]

Is your feature request related to a problem? Please describe.
I have two "problems":

1. currently, when environment.name is a variable and gets expanded, it will make a slug of the variable rather than the end result. E.g. if environment.name is $some_other_var, I will end up with a slug like some-other-var. environment.name itself will be properly expanded to whatever is in $some_other_var.
2. the slug does not match what gitlab itself generates (see https://gitlab.com/gitlab-org/gitlab/-/blob/fc31e7ac344e53ebae182ea1dca183bdc0e2ea71/lib/gitlab/slug/environment.rb)

Describe the solution you'd like
These issues to be resolved ;) Which I've done, in this pull request: #1673

Describe alternatives you've considered
Before, I used to pass in the slug myself using --variable, but that's annoying with dynamic environment names (ours is based on the branch name, means I have to look it up from an actual gitlab job first)

Additional context
n/a

[peterbbeu]

@firecow I'm not sure why the test (https://github.com/firecow/gitlab-ci-local/actions/runs/19068414845/job/54495176592#step:5:876) is failing, it seems to be the test being flaky, it's giving an HTTP 500 on some web request. I don't think it's related to the PR.

[firecow]

I reran it, you are right its flaky

[firecow]

#1673 Closed this issue