cleanup: simplify the edit-action API (#283)

Author: Meir017

src/FluentAssertions.Analyzers/Tips/DocumentEditorUtils.cs

@@ -18,8 +18,8 @@ public static CreateChangedDocument RenameMethodToSubjectShouldAssertion(IInvoca
         var invocationExpression = (InvocationExpressionSyntax)invocation.Syntax;
 
         return async ctx => await RewriteExpression(invocationExpression, [
-            ..Array.ConvertAll(argumentsToRemove, arg => new RemoveNodeAction(invocationExpression.ArgumentList.Arguments[arg])),
-            new SubjectShouldAssertionAction(subjectIndex, newName)
+            ..Array.ConvertAll(argumentsToRemove, arg => EditAction.RemoveNode(invocationExpression.ArgumentList.Arguments[arg])),
+            EditAction.SubjectShouldAssertion(subjectIndex, newName)
         ], context, ctx);
     }
 
@@ -30,8 +30,8 @@ public static CreateChangedDocument RenameMethodToSubjectShouldGenericAssertion(
         var invocationExpression = (InvocationExpressionSyntax)invocation.Syntax;
 
         return async ctx => await RewriteExpression(invocationExpression, [
-             ..Array.ConvertAll(argumentsToRemove, arg => new RemoveNodeAction(invocationExpression.ArgumentList.Arguments[arg])),
-                new SubjectShouldGenericAssertionAction(subjectIndex, newName, genericTypes)
+             ..Array.ConvertAll(argumentsToRemove, arg => EditAction.RemoveNode(invocationExpression.ArgumentList.Arguments[arg])),
+                EditAction.SubjectShouldGenericAssertion(subjectIndex, newName, genericTypes)
          ], context, ctx);
     }
 
@@ -40,21 +40,20 @@ public static CreateChangedDocument RenameMethodToSubjectShouldAssertionWithOpti
         var invocationExpression = (InvocationExpressionSyntax)invocation.Syntax;
 
         return async ctx => await RewriteExpression(invocationExpression, [
-            new SubjectShouldAssertionAction(subjectIndex, newName),
-                new CreateEquivalencyAssertionOptionsLambda(optionsIndex)
+            EditAction.SubjectShouldAssertion(subjectIndex, newName),
+            EditAction.CreateEquivalencyAssertionOptionsLambda(optionsIndex)
         ], context, ctx);
     }
 
-    private static async Task<Document> RewriteExpression(InvocationExpressionSyntax invocationExpression, IEditAction[] actions, CodeFixContext context, CancellationToken cancellationToken)
+    private static async Task<Document> RewriteExpression(InvocationExpressionSyntax invocationExpression, Action<DocumentEditor, InvocationExpressionSyntax>[] actions, CodeFixContext context, CancellationToken cancellationToken)
     {
         var editor = await DocumentEditor.CreateAsync(context.Document, cancellationToken);
 
         foreach (var action in actions)
         {
-            action.Apply(editor, invocationExpression);
+            action(editor, invocationExpression);
         }
 
         return editor.GetChangedDocument();
     }
 }
-

src/FluentAssertions.Analyzers/Tips/Editing/CreateEquivalencyAssertionOptionsLambda.cs

@@ -3,7 +3,7 @@
 
 namespace FluentAssertions.Analyzers;
 
-public class CreateEquivalencyAssertionOptionsLambda(int argumentIndex) : IEditAction
+public class CreateEquivalencyAssertionOptionsLambdaAction(int argumentIndex) : IEditAction
 {
     public void Apply(DocumentEditor editor, InvocationExpressionSyntax invocationExpression)
     {

src/FluentAssertions.Analyzers/Tips/Editing/EditAction.cs

@@ -0,0 +1,22 @@
+using System;
+using System.Collections.Immutable;
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CSharp.Syntax;
+using Microsoft.CodeAnalysis.Editing;
+
+namespace FluentAssertions.Analyzers;
+
+public static class EditAction
+{
+    public static Action<DocumentEditor, InvocationExpressionSyntax> RemoveNode(SyntaxNode node)
+        => (editor, invocationExpression) => editor.RemoveNode(node);
+
+    public static Action<DocumentEditor, InvocationExpressionSyntax> SubjectShouldAssertion(int argumentIndex, string assertion)
+        => (editor, invocationExpression) => new SubjectShouldAssertionAction(argumentIndex, assertion).Apply(editor, invocationExpression);
+
+    public static Action<DocumentEditor, InvocationExpressionSyntax> SubjectShouldGenericAssertion(int argumentIndex, string assertion, ImmutableArray<ITypeSymbol> genericTypes)
+        => (editor, invocationExpression) => new SubjectShouldGenericAssertionAction(argumentIndex, assertion, genericTypes).Apply(editor, invocationExpression);
+
+    public static Action<DocumentEditor, InvocationExpressionSyntax> CreateEquivalencyAssertionOptionsLambda(int optionsIndex)
+        => (editor, invocationExpression) => new CreateEquivalencyAssertionOptionsLambdaAction(optionsIndex).Apply(editor, invocationExpression);
+}