Merge pull request #32 from flutter-webrtc/fix/dc-data-parse

cloudwebrtc · web-flow · commit 8446e95c4c23 · 2024-04-09T09:00:28.000+08:00
Fix DC data parse.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 
 --------------------------------------------
+[1.3.3] - 2024-04-09
+
+* Fix DC data parse.
+
 [1.3.2] - 2024-04-09
 
 * Fix error when constructing RTCDataChannelInit.
diff --git a/lib/src/rtc_data_channel_impl.dart b/lib/src/rtc_data_channel_impl.dart
@@ -70,12 +70,10 @@ class RTCDataChannelWeb extends RTCDataChannel {
       return RTCDataChannelMessage(data);
     }
     dynamic arrayBuffer;
-    if (data is web.Blob) {
-      // This should never happen actually
-      arrayBuffer = await jsutil
-          .promiseToFuture(jsutil.callMethod(data, 'arrayBuffer', []));
+    if (data is JSArrayBuffer) {
+      arrayBuffer = data.toDart;
     } else {
-      arrayBuffer = data;
+      arrayBuffer = data.toString();
     }
     return RTCDataChannelMessage.fromBinary(arrayBuffer.asUint8List());
   }
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: dart_webrtc
 description: Use the dart/js library to re-wrap the webrtc js interface of the browser, to adapted common browsers.
-version: 1.3.2
+version: 1.3.3
 homepage: https://github.com/flutter-webrtc/dart-webrtc
 
 environment:

Original file line number	Diff line number	Diff line change
`@@ -70,12 +70,10 @@ class RTCDataChannelWeb extends RTCDataChannel {`
`70`	`70`	`return RTCDataChannelMessage(data);`
`71`	`71`	`}`
`72`	`72`	`dynamic arrayBuffer;`
`73`		`- if (data is web.Blob) {`
`74`		`- // This should never happen actually`
`75`		`- arrayBuffer = await jsutil`
`76`		`- .promiseToFuture(jsutil.callMethod(data, 'arrayBuffer', []));`
	`73`	`+ if (data is JSArrayBuffer) {`
	`74`	`+ arrayBuffer = data.toDart;`
`77`	`75`	`} else {`
`78`		`- arrayBuffer = data;`
	`76`	`+ arrayBuffer = data.toString();`
`79`	`77`	`}`
`80`	`78`	`return RTCDataChannelMessage.fromBinary(arrayBuffer.asUint8List());`
`81`	`79`	`}`