helmrepo: Remove migration log event

darkowlzz · darkowlzz · commit a242bdabed1c · 2023-12-14T15:31:02.000+05:30
This will be logged/event emitted forever once in the lifecycle of
HelmRepository OCI object because all new objects have to remove the
.status.observedGeneration which is set to -1 by the API defaulting.
Better to perform the object conversion internally without any log or
event.

Signed-off-by: Sunny &lt;darkowlzz@protonmail.com&gt;
diff --git a/internal/controller/helmrepository_controller.go b/internal/controller/helmrepository_controller.go
@@ -727,7 +727,5 @@ func (r *HelmRepositoryReconciler) migrationToStatic(ctx context.Context, sp *pa
 		return ctrl.Result{}, err
 	}
 
-	r.eventLogf(ctx, obj, eventv1.EventTypeTrace, "Migration",
-		"removed artifact and finalizer to migrate to static HelmRepository of type OCI")
 	return ctrl.Result{}, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,5 @@ func (r HelmRepositoryReconciler) migrationToStatic(ctx context.Context, sp pa`
`727`	`727`	`return ctrl.Result{}, err`
`728`	`728`	`}`
`729`	`729`
`730`		`- r.eventLogf(ctx, obj, eventv1.EventTypeTrace, "Migration",`
`731`		`- "removed artifact and finalizer to migrate to static HelmRepository of type OCI")`
`732`	`730`	`return ctrl.Result{}, nil`
`733`	`731`	`}`