Skip to content

Commit 17d044c

Browse files
committed
Updated issue instance id calculation to handle duplicate files
1 parent 2be900c commit 17d044c

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

sampleData/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
*.gitignore.*

src/main/java/com/fortify/ssc/parser/owasp/dependencycheck/domain/Dependency.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ public final String getFilePathOrName() {
4444
}
4545

4646
public final String getDependencyIdentifier() {
47-
return StringUtils.defaultIfBlank(sha256,
48-
StringUtils.defaultIfBlank(sha1,
49-
StringUtils.defaultIfBlank(md5, getFilePathOrName())));
47+
return getFilePathOrName() + "-" + StringUtils.defaultIfBlank(sha256,
48+
StringUtils.defaultIfBlank(sha1, md5));
5049
}
5150
}

src/test/java/com/fortify/ssc/parser/owasp/dependencycheck/OWASPDependencyCheckParserPluginTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,10 @@
4444

4545
class OWASPDependencyCheckParserPluginTest {
4646
private static final String[] SAMPLE_FILES = {
47-
//"dependency-check-report-java.json",
48-
//"dependency-check-report-php.json",
47+
"dependency-check-report-java.json",
48+
"dependency-check-report-php.json",
4949
"dependency-check-report-with-npm.json",
50+
//"dependency-check-report.gitignore.json"
5051
};
5152

5253
private final ScanData getScanData(final String fileName) {

0 commit comments

Comments
 (0)