Skip to content

Conversation

@jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Nov 29, 2025

Following #1050 , the directory include must be also included in the branch stdlib-fpm

@jvdp1 jvdp1 requested review from jalvesz and perazz November 29, 2025 21:19
@jvdp1
Copy link
Member Author

jvdp1 commented Nov 29, 2025

@jalvesz I forgot to copy the include directory in for the stdlib-fpm branch. Should we add a CI for checking that stdlib-fpm is fine?
Note: There is one. Strange that it was not catched in #1050

@jvdp1 jvdp1 changed the title Include the directory include in stdlib-fpm Fix: include the directory include in stdlib-fpm Nov 30, 2025
Copy link
Member

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jvdp1. The fact that included files in stdlib should have .inc extension and they should be located in include/ could perhaps be standardized somewhere either in the style guide or in the contributing docs?

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.93%. Comparing base (bb86830) to head (4527cf4).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1062       +/-   ##
===========================================
+ Coverage   25.14%   68.93%   +43.78%     
===========================================
  Files         570      390      -180     
  Lines      234225    12650   -221575     
  Branches    41285     1377    -39908     
===========================================
- Hits        58903     8720    -50183     
+ Misses     175322     3930   -171392     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jvdp1
Copy link
Member Author

jvdp1 commented Nov 30, 2025

LGTM @jvdp1. The fact that included files in stdlib should have .inc extension and they should be located in include/ could perhaps be standardized somewhere either in the style guide or in the contributing docs?

Thank you @perazz! Good point! It is now added in STYLE_GUIDE.md with this commit

toolchain: {compiler: gcc, version: '13' }

steps:
- name: Checkout code
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behaviour had to be changed. It was using stdlib-fpm avalailble on github and that do not include the changes in the PR. Therefore, the new changes proposed in a PR were not included in the coverage analyses.

Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jvdp1 thanks for catching this one!!

@jvdp1
Copy link
Member Author

jvdp1 commented Nov 30, 2025

Thank you @perazz and @jalvesz . I will merge it now to avoid generating issues for users of stdlib-fpm

@jvdp1 jvdp1 merged commit caa060c into fortran-lang:master Nov 30, 2025
24 checks passed
@jvdp1 jvdp1 deleted the fix_fypp_deployment branch November 30, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants