-
Notifications
You must be signed in to change notification settings - Fork 206
Fix: include the directory include in stdlib-fpm #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
perazz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jvdp1. The fact that included files in stdlib should have .inc extension and they should be located in include/ could perhaps be standardized somewhere either in the style guide or in the contributing docs?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
===========================================
+ Coverage 25.14% 68.93% +43.78%
===========================================
Files 570 390 -180
Lines 234225 12650 -221575
Branches 41285 1377 -39908
===========================================
- Hits 58903 8720 -50183
+ Misses 175322 3930 -171392 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thank you @perazz! Good point! It is now added in |
| toolchain: {compiler: gcc, version: '13' } | ||
|
|
||
| steps: | ||
| - name: Checkout code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behaviour had to be changed. It was using stdlib-fpm avalailble on github and that do not include the changes in the PR. Therefore, the new changes proposed in a PR were not included in the coverage analyses.
jalvesz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jvdp1 thanks for catching this one!!
Following #1050 , the directory
includemust be also included in the branchstdlib-fpm