Merge pull request #762 from fortran-lang/gnikit/issue744

feat(log): draw focus sometimes on log channel

Author: gnikit

CHANGELOG.md

@@ -49,6 +49,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 
+- Changed logger to draw focus on certain error messages
+  ([#744](https://github.com/fortran-lang/vscode-fortran-support/issues/744))
 - Changed the way extension Release Notes are displayed
   ([#723](https://github.com/fortran-lang/vscode-fortran-support/issues/723))
 - Changed the activation events of the extension to include the `onCommand` for all register commands

src/features/formatting-provider.ts

@@ -50,6 +50,7 @@ export class FortranFormattingProvider implements vscode.DocumentFormattingEditP
       this.logger.error(
         `[format] fprettify can only format FortranFreeForm, change to findent for FortranFixedForm formatting`
       );
+      this.logger.show(true); // Keep focus on editor
       return undefined;
     }
     return this.spawnFormatBase(document, 'fprettify', ['--stdout']);
@@ -101,6 +102,7 @@ export class FortranFormattingProvider implements vscode.DocumentFormattingEditP
 
     if (!FORMATTERS.includes(this.formatter)) {
       this.logger.error(`[format] Unsupported formatter: ${this.formatter}`);
+      this.logger.show(true); // Keep focus on editor
     }
     return this.formatter;
   }

src/features/linter-provider.ts

@@ -430,6 +430,7 @@ export class FortranLintingProvider {
       return;
     } catch (err) {
       this.logger.error(`[build] Compiling ${textDocument.fileName} failed:`, err);
+      this.logger.show(true); // Keep focus on editor
       console.error(`ERROR: ${err}`);
     }
   }

src/lsp/client.ts

@@ -265,6 +265,7 @@ export class FortlsClient {
     const results = spawnSync(executablePath, args.concat(['--version']));
     if (results.error) {
       this.logger.error(`[lsp.client] Unable to launch LS to check version:`, results.error);
+      this.logger.show();
       const selected = window.showErrorMessage(
         'Modern Fortran Error starting fortls: Check that fortls is in your PATH or that "fortran.fortls.path" is pointing to a fortls binary.',
         'Settings',
@@ -282,6 +283,7 @@ export class FortlsClient {
     }
     if (results.status !== 0) {
       this.logger.error(`[lsp.client] Unable to verify input arguments with LS:`);
+      this.logger.show();
       const selected = window.showErrorMessage(
         'Error launching fortls: Please check that all selected options are supported by your language server version.',
         'Settings',

src/services/logging.ts

@@ -71,8 +71,8 @@ export class Logger {
     }
   }
 
-  public show() {
-    this.channel.show();
+  public show(preserveFocus?: boolean) {
+    this.channel.show(preserveFocus);
   }
 
   private logObject(data: unknown): void {