Fixes formatter detection check

Also adds output on successfull install.
There is still a problem with the install tool returning a promise
that is being fullfied after we have executed the formatter
(that is if the tool is missing) which results into the user having
to call the formatter twice to format the document.

Author: gnikit

src/features/formatting-provider.ts

@@ -45,16 +45,14 @@ export class FortranFormattingProvider implements vscode.DocumentFormattingEditP
 
     const formatterName = 'fprettify';
     const formatterPath: string = this.getFormatterPath();
-    // If no formatter path is present check that formatter is present in $PATH
-    if (!formatterPath) {
-      if (!which.sync(formatterName, { nothrow: true })) {
-        this.logger.logWarning(`Formatter: ${formatterName} not detected in your system.
+    const formatter: string = path.join(formatterPath, formatterName);
+    // If no formatter is detected try and install it
+    if (!which.sync(formatter, { nothrow: true })) {
+      this.logger.logWarning(`Formatter: ${formatterName} not detected in your system.
                                 Attempting to install now.`);
-        const msg = `Installing ${formatterName} through pip with --user option`;
-        promptForMissingTool(formatterName, msg, 'Python');
-      }
+      const msg = `Installing ${formatterName} through pip with --user option`;
+      promptForMissingTool(formatterName, msg, 'Python');
     }
-    const formatter: string = path.join(formatterPath, formatterName);
 
     const args: string[] = [document.fileName, ...this.getFormatterArgs()];
     // args.push('--silent'); // TODO: pass?
@@ -86,16 +84,14 @@ export class FortranFormattingProvider implements vscode.DocumentFormattingEditP
   private doFormatFindent(document: vscode.TextDocument) {
     const formatterName = 'findent';
     const formatterPath: string = this.getFormatterPath();
-    // If no formatter path is present check that formatter is present in $PATH
-    if (!formatterPath) {
-      if (!which.sync(formatterName, { nothrow: true })) {
-        this.logger.logWarning(`Formatter: ${formatterName} not detected in your system.
-                                Attempting to install now.`);
-        const msg = `Installing ${formatterName} through pip with --user option`;
-        promptForMissingTool(formatterName, msg, 'Python');
-      }
-    }
     let formatter: string = path.join(formatterPath, formatterName);
+    // If no formatter is detected try and install it
+    if (!which.sync(formatter, { nothrow: true })) {
+      this.logger.logWarning(`Formatter: ${formatterName} not detected in your system.
+                                    Attempting to install now.`);
+      const msg = `Installing ${formatterName} through pip with --user option`;
+      promptForMissingTool(formatterName, msg, 'Python');
+    }
 
     // Annoyingly findent only outputs to a file and not to a stream so
     // let us go and create a temporary file

src/lib/tools.ts

@@ -75,6 +75,7 @@ export function promptForMissingTool(
 
             default:
               logger.logError(`Failed to install tool: ${tool}`);
+              vscode.window.showErrorMessage(`Failed to install tool: ${tool}`);
               break;
           }
         }
@@ -100,6 +101,8 @@ export function installPythonTool(pyPackage: string, logger?: LoggingService) {
       logger.logError(
         `Python package ${pyPackage} failed to install with code: ${code}, signal: ${signal}`
       );
+    } else {
+      logger.logInfo(`Successfully installed ${pyPackage}.`);
     }
   });
   installProcess.on('error', err => {