Add circleci to run flake8 (#28)

* Add files required for circleci

* Add circleCI badge

* Show the error while also storing it

* Fix up linting issues

Add a default config
Fix outputting results from flake8

* Actually update flake8 command

* Fix E722 do not use bare except

Author: psykzz

.circleci/config.yml

@@ -0,0 +1,37 @@
+# Python CircleCI 2.0 configuration file
+version: 2
+jobs:
+  build:
+    docker:
+      - image: circleci/python:3.6.4
+
+    steps:
+      - checkout
+
+      - restore_cache:
+          keys:
+          - v1-dependencies-{{ checksum "requirements.txt" }}
+          - v1-dependencies-
+
+      - run:
+          name: install dependencies
+          command: |
+            python3 -m venv venv
+            . venv/bin/activate
+            pip install -r requirements.txt
+
+      - save_cache:
+          paths:
+            - ./venv
+          key: v1-dependencies-{{ checksum "requirements.txt" }}
+
+      - run:
+          name: run linting and metrics
+          command: |
+            python3 -m venv venv
+            . venv/bin/activate
+            flake8 . --output-file test-reports --tee --statistics
+
+      - store_artifacts:
+          path: test-reports
+          destination: test-reports

.gitignore

@@ -87,3 +87,6 @@ ENV/
 
 # Rope project settings
 .ropeproject
+
+# Additions
+test-reports

README.md

@@ -1,5 +1,6 @@
 [![GitHub contributors](https://img.shields.io/github/contributors/psykzz/st3-gitblame.svg)](https://github.com/psykzz/st3-gitblame/graphs/contributors)
 [![GitHub issues](https://img.shields.io/github/issues/psykzz/st3-gitblame.svg)](https://github.com/psykzz/st3-gitblame/issues)
+[![CircleCI](https://circleci.com/gh/psykzz/st3-gitblame.svg?style=svg)](https://circleci.com/gh/psykzz/st3-gitblame)
 
 
 # Git blame - Sublime text 3 plugin

git-blame.py

@@ -103,7 +103,7 @@
 try:
     si = subprocess.STARTUPINFO()
     si.dwFlags |= subprocess.STARTF_USESHOWWINDOW
-except:
+except Exception:
     si = None
 
 
@@ -116,11 +116,12 @@ def __init__(self, view):
     @functools.lru_cache(128, False)
     def get_blame(self, line, path):
         try:
-            return shell(["git", "blame", "--minimal", "-w",
-                "-L {0},{0}".format(line), path],
+            return shell(
+                ["git", "blame", "--minimal", "-w", "-L {0},{0}".format(line), path],
                 cwd=os.path.dirname(os.path.realpath(path)),
                 startupinfo=si,
-                stderr=subprocess.STDOUT)
+                stderr=subprocess.STDOUT
+            )
         except subprocess.CalledProcessError as e:
             print("Git blame: git error {}:\n{}".format(e.returncode, e.output.decode("UTF-8")))
         except Exception as e:
@@ -145,9 +146,11 @@ def parse_blame(self, blame):
 
     def get_commit(self, sha, path):
         try:
-            return shell(["git", "show", sha],
+            return shell(
+                ["git", "show", sha],
                 cwd=os.path.dirname(os.path.realpath(path)),
-                startupinfo=si)
+                startupinfo=si
+            )
         except Exception as e:
             return
 
@@ -182,8 +185,9 @@ def run(self, edit):
 
         phantoms = []
         self.view.erase_phantoms('git-blame')
-        #Before adding the phantom, see if the current phantom that is displayed is at the same spot at the selection
-        if self.phantom_set.phantoms and self.view.line(self.view.sel()[0]) == self.view.line(self.phantom_set.phantoms[0].region):
+        # Before adding the phantom, see if the current phantom that is displayed is at the same spot at the selection
+        phantom_exists = self.view.line(self.view.sel()[0]) == self.view.line(self.phantom_set.phantoms[0].region)
+        if self.phantom_set.phantoms and phantom_exists:
             self.phantom_set.update(phantoms)
             return
 
@@ -265,10 +269,12 @@ def get_blame_lines(self, path):
         try:
             # The option --show-name is necessary to force file name display.
             command = ["git", "blame", "--show-name", "--minimal", "-w", path]
-            output = shell(command,
+            output = shell(
+                command,
                 cwd=os.path.dirname(os.path.realpath(path)),
                 startupinfo=si,
-                stderr=subprocess.STDOUT)
+                stderr=subprocess.STDOUT
+            )
             return output.decode("UTF-8").splitlines()
         except subprocess.CalledProcessError as e:
             print("Git blame: git error {}:\n{}".format(e.returncode, e.output.decode("UTF-8")))

requirements.txt

@@ -0,0 +1 @@
+flake8

tox.ini

@@ -0,0 +1,4 @@
+[flake8]
+exclude = .git,__pycache__,venv
+max-complexity = 10
+max-line-length = 120