Fix flow definitions for base.js

Author: BlooJeans

lib/modules/base.js

@@ -11,8 +11,9 @@ const FirestackModuleEvt = new NativeEventEmitter(FirestackModule);
 
 const logs = {};
 
+type FirestackOptions = {};
 export class Base extends EventEmitter {
-  constructor(firestack, options = {}) {
+  constructor(firestack: Object, options: FirestackOptions = {}) {
     super();
     this.firestack = firestack;
     this.eventHandlers = {};
@@ -22,7 +23,7 @@ export class Base extends EventEmitter {
   }
 
   // Logger
-  get log() {
+  get log(): Log {
     if (!logs[this.namespace]) {
       const debug = this.firestack._debug;
       logs[this.namespace] = new Log(this.namespace, debug);
@@ -38,7 +39,7 @@ export class Base extends EventEmitter {
   }
 
   // TODO unused - do we need this anymore?
-  _addToFirestackInstance(...methods) {
+  _addToFirestackInstance(...methods: Array<string>) {
     methods.forEach(name => {
       this.firestack[name] = this[name].bind(this);
     })
@@ -47,15 +48,17 @@ export class Base extends EventEmitter {
   /**
    * app instance
    **/
-  get app() {
+  get app(): Object {
     return this.firestack.app;
   }
 
-  whenReady(fn) {
-    return this.firestack.configurePromise.then(fn);
+  whenReady(promise: Promise<*>): Promise<*> {
+    return this.firestack.configurePromise.then((result) => {
+      return promise;
+    });
   }
 
-  get namespace() {
+  get namespace(): string {
     return 'firestack:base';
   }
 
@@ -88,25 +91,21 @@ export class Base extends EventEmitter {
 }
 
 export class ReferenceBase extends Base {
-  constructor(firestack, path) {
+  constructor(firestack: Object, path: Array<string> | string) {
     super(firestack);
 
-    this.path = Array.isArray(path) ?
-      path :
-      (typeof path == 'string' ?
-        [path] : []);
+    this.path = Array.isArray(path) ?  path : (typeof path == 'string' ?  [path] : []);
 
     // sanitize path, just in case
-    this.path = this.path
-      .filter(str => str !== "");
+    this.path = this.path.filter(str => str !== '');
   }
 
-  get key() {
+  get key(): string {
     const path = this.path;
     return path.length === 0 ? '/' : path[path.length - 1];
   }
 
-  pathToString() {
+  pathToString(): string {
     let path = this.path;
     let pathStr = (path.length > 0 ? path.join('/') : '/');
     if (pathStr[0] != '/') {