fix: implement _remove

gajus · gajus · commit a9c6f0ee7701 · 2022-08-01T20:29:39.000-05:00
diff --git a/README.md b/README.md
@@ -48,7 +48,6 @@ Known incompatibilities:
 
 * `connection.processID` not implemented
 * `pool._pulseQueue` not implemented
-* `pool._remove` not implemented
 
 Please submit PR if you require additional compatibility.
 
diff --git a/src/bridge.ts b/src/bridge.ts
@@ -127,8 +127,8 @@ export const createBridge = (postgres: typeof Postgres) => {
       // TODO implement logic equivalent to https://github.com/brianc/node-postgres/blob/master/packages/pg-pool/index.js#L109-L152
     }
 
-    public _remove () {
-      // TODO implement logic equivalent to https://github.com/brianc/node-postgres/blob/master/packages/pg-pool/index.js#L154-L164
+    public async _remove (client: {end: () => Promise<void>, }) {
+      await client.end();
     }
 
     public get idleCount () {

Original file line number	Diff line number	Diff line change
`@@ -127,8 +127,8 @@ export const createBridge = (postgres: typeof Postgres) => {`
`127`	`127`	`// TODO implement logic equivalent to https://github.com/brianc/node-postgres/blob/master/packages/pg-pool/index.js#L109-L152`
`128`	`128`	`}`
`129`	`129`
`130`		`- public _remove () {`
`131`		`- // TODO implement logic equivalent to https://github.com/brianc/node-postgres/blob/master/packages/pg-pool/index.js#L154-L164`
	`130`	`+ public async _remove (client: {end: () => Promise<void>, }) {`
	`131`	`+ await client.end();`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`public get idleCount () {`