Skip to content

Commit 000d215

Browse files
authored
update(GHA): Various updates to gemini-review.yml (#97)
* Add artifact names to rgcli workflow steps * Specify artifact uploading * Update workflows to current rgcli * Pin mcp server to v18
1 parent 0fb437b commit 000d215

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

.github/workflows/gemini-review.yml

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
permission-contents: 'read'
4141
permission-issues: 'write'
4242
permission-pull-requests: 'write'
43-
43+
4444
- name: 'Acknowledge request'
4545
env:
4646
GITHUB_TOKEN: '${{ steps.mint_identity_token.outputs.token || secrets.GITHUB_TOKEN || github.token }}'
@@ -65,6 +65,7 @@ jobs:
6565
ISSUE_BODY: '${{ github.event.pull_request.body || github.event.issue.body }}'
6666
PULL_REQUEST_NUMBER: '${{ github.event.pull_request.number || github.event.issue.number }}'
6767
REPOSITORY: '${{ github.repository }}'
68+
ADDITIONAL_CONTEXT: '${{ inputs.additional_context }}'
6869
with:
6970
gcp_location: '${{ vars.GOOGLE_CLOUD_LOCATION }}'
7071
gcp_project_id: '${{ vars.GOOGLE_CLOUD_PROJECT }}'
@@ -77,14 +78,16 @@ jobs:
7778
google_api_key: '${{ secrets.GOOGLE_API_KEY }}'
7879
use_gemini_code_assist: '${{ vars.GOOGLE_GENAI_USE_GCA }}'
7980
use_vertex_ai: '${{ vars.GOOGLE_GENAI_USE_VERTEXAI }}'
81+
upload_artifacts: '${{ vars.UPLOAD_ARTIFACTS }}'
8082
settings: |-
8183
{
8284
"model": {
8385
"maxSessionTurns": 25
8486
},
8587
"telemetry": {
86-
"enabled": ${{ vars.GOOGLE_CLOUD_PROJECT != '' }},
87-
"target": "gcp"
88+
"enabled": true,
89+
"target": "local",
90+
"outfile": ".gemini/telemetry.log"
8891
},
8992
"mcpServers": {
9093
"github": {
@@ -95,7 +98,7 @@ jobs:
9598
"--rm",
9699
"-e",
97100
"GITHUB_PERSONAL_ACCESS_TOKEN",
98-
"ghcr.io/github/github-mcp-server"
101+
"ghcr.io/github/github-mcp-server:v0.18.0"
99102
],
100103
"includeTools": [
101104
"add_comment_to_pending_review",
@@ -128,6 +131,7 @@ jobs:
128131
ISSUE_BODY: '${{ github.event.pull_request.body || github.event.issue.body }}'
129132
PULL_REQUEST_NUMBER: '${{ github.event.pull_request.number || github.event.issue.number }}'
130133
REPOSITORY: '${{ github.repository }}'
134+
ADDITIONAL_CONTEXT: '${{ inputs.additional_context }}'
131135
with:
132136
gcp_location: '${{ vars.GOOGLE_CLOUD_LOCATION }}'
133137
gcp_project_id: '${{ vars.GOOGLE_CLOUD_PROJECT }}'
@@ -140,6 +144,7 @@ jobs:
140144
google_api_key: '${{ secrets.GOOGLE_API_KEY }}'
141145
use_gemini_code_assist: '${{ vars.GOOGLE_GENAI_USE_GCA }}'
142146
use_vertex_ai: '${{ vars.GOOGLE_GENAI_USE_VERTEXAI }}'
147+
upload_artifacts: '${{ vars.UPLOAD_ARTIFACTS }}'
143148
extensions: |
144149
[
145150
"https://github.com/gemini-cli-extensions/security.git"
@@ -150,8 +155,9 @@ jobs:
150155
"maxSessionTurns": 100
151156
},
152157
"telemetry": {
153-
"enabled": ${{ vars.GOOGLE_CLOUD_PROJECT != '' }},
154-
"target": "gcp"
158+
"enabled": true,
159+
"target": "local",
160+
"outfile": ".gemini/telemetry.log"
155161
},
156162
"mcpServers": {
157163
"github": {
@@ -162,7 +168,7 @@ jobs:
162168
"--rm",
163169
"-e",
164170
"GITHUB_PERSONAL_ACCESS_TOKEN",
165-
"ghcr.io/github/github-mcp-server"
171+
"ghcr.io/github/github-mcp-server:v0.18.0"
166172
],
167173
"includeTools": [
168174
"add_comment_to_pending_review",

0 commit comments

Comments
 (0)