Skip to content

Commit f9747a0

Browse files
authored
Raise ProviderTileNotFoundError instead of returning (#2101)
* Raise provider error Fix typo that returned ProviderTileNotFoundError instead of raising it * Fix tests
1 parent bc76849 commit f9747a0

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

pygeoapi/provider/mvt_postgresql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def get_tiles(self, layer='default', tileset=None,
151151
]
152152
if not self.is_in_limits(tileset_schema, z, x, y):
153153
LOGGER.warning(f'Tile {z}/{x}/{y} not found')
154-
return ProviderTileNotFoundError
154+
raise ProviderTileNotFoundError
155155

156156
storage_srid = get_crs_from_uri(self.storage_crs).to_string()
157157
out_srid = get_crs_from_uri(tileset_schema.crs).to_string()

tests/provider/test_postgresql_mvt_provider.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,11 @@ def test_get_tiles_WebMercatorQuad(config):
271271

272272
# Tile does not exist in matrixset
273273
z, x, y = 1, 1000000, 1000000
274-
result = p.get_tiles(
275-
tileset=tileset,
276-
z=z, x=x, y=y
277-
)
278-
assert result == ProviderTileNotFoundError
274+
with pytest.raises(ProviderTileNotFoundError):
275+
p.get_tiles(
276+
tileset=tileset,
277+
z=z, x=x, y=y
278+
)
279279

280280

281281
def test_get_tiles_WorldCRS84Quad(config):
@@ -311,8 +311,8 @@ def test_get_tiles_WorldCRS84Quad(config):
311311

312312
# Tile does not exist in matrixset
313313
z, x, y = 1, 1000000, 1000000
314-
result = p.get_tiles(
315-
tileset=tileset,
316-
z=z, x=x, y=y
317-
)
318-
assert result == ProviderTileNotFoundError
314+
with pytest.raises(ProviderTileNotFoundError):
315+
p.get_tiles(
316+
tileset=tileset,
317+
z=z, x=x, y=y
318+
)

0 commit comments

Comments
 (0)