Update Azure Functions guide to use OpenTelemetry #15568
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle ReportChanges will increase total bundle size by 409.73kB (1.18%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
I believe there is an issue with the 'performance' product button.
See https://github.com/getsentry/sentry-docs/pull/15568/files#r2565809885.
EDIT: Already addressed
| // ___PRODUCT_OPTION_START___ performance | ||
| .ConfigureServices(services => | ||
| { | ||
| services.AddOpenTelemetry().WithTracing(builder => |
There was a problem hiding this comment.
question: Do we need to add a PackageReference to OpenTelemetry.Extensions.Hosting to the Install section?
Or at least mention it in a comment?
services.AddOpenTelemetry().WithTracing(builder => // from OpenTelemetry.Extensions.HostingThere was a problem hiding this comment.
I've added the OpenTelemetry packages... not the AzureFunctions ones as I think it's implicit folks have those already for an AF application.
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| dotnet add package Sentry.Extensions.Logging -v {{@inject packages.version('sentry.dotnet.extensions.logging') }} | ||
| // ___PRODUCT_OPTION_START___ performance | ||
| dotnet add package Sentry.OpenTelemetry -v {{@inject packages.version('sentry.dotnet.opentelemetry') }} |
There was a problem hiding this comment.
This renders fine in the preview. I don't see any reason to change this.
| // ___PRODUCT_OPTION_START___ performance | ||
| .ConfigureServices(services => | ||
| { | ||
| services.AddOpenTelemetry().WithTracing(builder => |
There was a problem hiding this comment.
I've added the OpenTelemetry packages... not the AzureFunctions ones as I think it's implicit folks have those already for an AF application.
DESCRIBE YOUR PR
Resolves getsentry/sentry-dotnet#4726
See also:
IS YOUR CHANGE URGENT?
SLA
cc: @Flash0ver
PRE-MERGE CHECKLIST