Commit 87c8e14
fix(core): Stop awaiting build start telemetry to avoid breaking module federation builds (#818)
* fix(core): Stop awaiting build start telemetry to avoid breaking module
federation builds
Prior to this fix, we would create a span when the build starts and await
flushing it before proceeding with the build. This breaks when using module
federation builds as outlined in #816.
This fix removes the blocking await and optimistically fires off the span. This
**should** be fine as we definitely care more about not breaking user builds
than telemetry arriving. It could lead to us potentially missing this span
sometimes when builds run very fast and finish before the span flushes out,
however given that the build process usually takes longer (especially when
sourcemaps and uploading sourcemaps is involved) it should be fine most of the
time.
Closes: #816
* Update packages/bundler-plugin-core/src/index.ts
Co-authored-by: Jan Peer Stöcklmair <jan.oster94@gmail.com>
---------
Co-authored-by: Jan Peer Stöcklmair <jan.oster94@gmail.com>1 parent fb36641 commit 87c8e14
1 file changed
+9
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
81 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
82 | 89 | | |
83 | 90 | | |
84 | 91 | | |
| |||
0 commit comments