fix(core): Stop awaiting build start telemetry to avoid breaking module federation builds #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federation builds Prior to this fix, we would create a span when the build starts and await flushing it before proceeding with the build. This breaks when using module federation builds as outlined in #816. This fix removes the blocking await and optimistically fires off the span. This **should** be fine as we definitely care more about not breaking user builds than telemetry arriving. It could lead to us potentially missing this span sometimes when builds run very fast and finish before the span flushes out, however given that the build process usually takes longer (especially when sourcemaps and uploading sourcemaps is involved) it should be fine most of the time. Closes: #816
JPeer264
approved these changes
Oct 24, 2025
Co-authored-by: Jan Peer Stöcklmair <jan.oster94@gmail.com>
4 tasks
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 1, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.5.0 | 4.6.0 | ## [v4.6.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#460) - fix(core): Stop awaiting build start telemetry to avoid breaking module federation builds ([#818](getsentry/sentry-javascript-bundler-plugins#818)) - feat(core): Bump [@sentry/cli](https://github.com/sentry/cli) from 2.51.0 to 2.57.0 ([#819](getsentry/sentry-javascript-bundler-plugins#819))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 1, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.5.0 | 4.6.0 | ## [v4.6.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#460) - fix(core): Stop awaiting build start telemetry to avoid breaking module federation builds ([#818](getsentry/sentry-javascript-bundler-plugins#818)) - feat(core): Bump [@sentry/cli](https://github.com/sentry/cli) from 2.51.0 to 2.57.0 ([#819](getsentry/sentry-javascript-bundler-plugins#819))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix, we would create a span when the build starts and await flushing it before proceeding with the build. This breaks when using module federation builds as outlined in #816.
This fix removes the blocking await and optimistically fires off the span. This should be fine as we definitely care more about not breaking user builds than telemetry arriving. It could lead to us potentially missing this span sometimes when builds run very fast and finish before the span flushes out, however given that the build process usually takes longer (especially when sourcemaps and uploading sourcemaps is involved) it should be fine most of the time.
Closes: #816