Commit 090a3e3
authored
fix(node):
I guess this got through CI because we test latest 18 rather than
18.0.0.
This breaks [some supported Electron
versions](https://github.com/getsentry/sentry-electron/actions/runs/19306230917/job/55215745023)
which are using >18.0.0 but <18.19.0.
This wont have impacted almost anyone else because Otel requires
18.19.0!
```
[App] [ Main] App threw an error during load
[App] [ Main] file:///home/runner/work/sentry-electron/sentry-electron/test/e2e/dist/error-after-ready/node_modules/@sentry/node-core/build/esm/integrations/pino.js:1
[App] [ Main] import { tracingChannel } from 'node:diagnostics_channel';
[App] [ Main] ^^^^^^^^^^^^^^
[App] [ Main] SyntaxError: The requested module 'node:diagnostics_channel' does not provide an export named 'tracingChannel'
[App] [ Main] at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
[App] [ Main] at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)
[App] [ Main] A JavaScript error occurred in the main process
```tracingChannel export missing in older node versions (#18191)1 parent 2deb000 commit 090a3e3
1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
| 125 | + | |
| 126 | + | |
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| |||
0 commit comments