Remove isLikelyLazyRoute

Author: onurtemizkan

packages/react/src/reactrouter-compat-utils/index.ts

@@ -20,7 +20,6 @@ export {
   resolveRouteNameAndSource,
   getNormalizedName,
   initializeRouterUtils,
-  isLikelyLazyRouteContext,
   locationIsInsideDescendantRoute,
   prefixWithSlash,
   rebuildRoutePathFromAllRoutes,

packages/react/src/reactrouter-compat-utils/instrumentation.tsx

@@ -44,7 +44,6 @@ import { checkRouteForAsyncHandler } from './lazy-routes';
 import {
   getNormalizedName,
   initializeRouterUtils,
-  isLikelyLazyRouteContext,
   locationIsInsideDescendantRoute,
   prefixWithSlash,
   rebuildRoutePathFromAllRoutes,
@@ -577,16 +576,13 @@ export function handleNavigation(opts: {
       basename,
     );
 
-    // Check if this might be a lazy route context
-    const isLazyRouteContext = isLikelyLazyRouteContext(allRoutes || routes, location);
-
     const activeSpan = getActiveSpan();
     const spanJson = activeSpan && spanToJSON(activeSpan);
     const isAlreadyInNavigationSpan = spanJson?.op === 'navigation';
 
     // Cross usage can result in multiple navigation spans being created without this check
     if (!isAlreadyInNavigationSpan) {
-      createNewNavigationSpan(client, name, source, version, isLazyRouteContext);
+      createNewNavigationSpan(client, name, source, version);
     }
   }
 }
@@ -739,7 +735,6 @@ export function createNewNavigationSpan(
   name: string,
   source: TransactionSource,
   version: string,
-  isLikelyLazyRoute: boolean,
 ): void {
   const newSpan = startBrowserTracingNavigationSpan(client, {
     name,
@@ -750,8 +745,7 @@ export function createNewNavigationSpan(
     },
   });
 
-  // For lazy routes, don't mark as named yet so it can be updated later when the route loads
-  if (!isLikelyLazyRoute && newSpan) {
+  if (newSpan) {
     addNonEnumerableProperty(
       newSpan as { __sentry_navigation_name_set__?: boolean },
       '__sentry_navigation_name_set__',

packages/react/src/reactrouter-compat-utils/utils.ts

@@ -14,37 +14,6 @@ export function initializeRouterUtils(matchRoutes: MatchRoutes, stripBasename: b
   _stripBasename = stripBasename;
 }
 
-/**
- * Checks if the given routes or location context suggests this might be a lazy route scenario.
- * This helps determine if we should delay marking navigation spans as "named" to allow for updates
- * when lazy routes are loaded.
- */
-export function isLikelyLazyRouteContext(routes: RouteObject[], location: Location): boolean {
-  // Check if any route in the current match has lazy properties
-  const hasLazyRoute = routes.some(route => {
-    return (
-      // React Router lazy() route
-      route.lazy ||
-      // Route with async handlers that might load child routes
-      (route.handle &&
-        typeof route.handle === 'object' &&
-        Object.values(route.handle).some(handler => typeof handler === 'function'))
-    );
-  });
-
-  if (hasLazyRoute) {
-    return true;
-  }
-
-  // Check if current route is unmatched, which might indicate a lazy route that hasn't loaded yet
-  const currentMatches = _matchRoutes(routes, location);
-  if (!currentMatches || currentMatches.length === 0) {
-    return true;
-  }
-
-  return false;
-}
-
 // Helper functions
 function pickPath(match: RouteMatch): string {
   return trimWildcard(match.route.path || '');