Skip to content

Commit 94d00df

Browse files
committed
adjust integration test
1 parent 758d1cb commit 94d00df

File tree

1 file changed

+2
-10
lines changed
  • dev-packages/browser-integration-tests/suites/public-api/setTag/with_non_primitives

1 file changed

+2
-10
lines changed

dev-packages/browser-integration-tests/suites/public-api/setTag/with_non_primitives/test.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,11 @@ import type { Event } from '@sentry/core';
33
import { sentryTest } from '../../../../utils/fixtures';
44
import { getFirstSentryEnvelopeRequest } from '../../../../utils/helpers';
55

6-
sentryTest('[bug] accepts non-primitive tags', async ({ getLocalTestUrl, page }) => {
7-
// this is a bug that went unnoticed due to type definitions and a bad assertion
8-
// TODO: We should not accept non-primitive tags. Fix this as a follow-up.
6+
sentryTest("doesn't accept non-primitive tags", async ({ getLocalTestUrl, page }) => {
97
const url = await getLocalTestUrl({ testDir: __dirname });
108

119
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
1210

1311
expect(eventData.message).toBe('non_primitives');
14-
15-
// TODO: This should be an empty object but instead, it is:
16-
expect(eventData.tags).toEqual({
17-
tag_1: {},
18-
tag_2: [],
19-
tag_3: ['a', {}],
20-
});
12+
expect(eventData.tags).toEqual({});
2113
});

0 commit comments

Comments
 (0)