fix(browser): Add ok status to succesful idleSpans

[onurtemizkan]

This came up while working on improvements for React Router wildcard routes. Looks like the successful browser idleSpans are reported with unknown status at the moment.

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	24.59 kB	-	-
@sentry/browser - with treeshaking flags	23.09 kB	-	-
@sentry/browser (incl. Tracing)	41.25 kB	+0.06%	+22 B 🔺
@sentry/browser (incl. Tracing, Profiling)	45.52 kB	+0.05%	+20 B 🔺
@sentry/browser (incl. Tracing, Replay)	79.72 kB	+0.03%	+18 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	69.39 kB	+0.03%	+19 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	84.39 kB	+0.01%	+1 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	96.58 kB	+0.03%	+21 B 🔺
@sentry/browser (incl. Feedback)	41.27 kB	-	-
@sentry/browser (incl. sendFeedback)	29.26 kB	-	-
@sentry/browser (incl. FeedbackAsync)	34.19 kB	-	-
@sentry/react	26.28 kB	-	-
@sentry/react (incl. Tracing)	43.21 kB	+0.06%	+22 B 🔺
@sentry/vue	29.07 kB	-	-
@sentry/vue (incl. Tracing)	43.02 kB	+0.05%	+20 B 🔺
@sentry/svelte	24.6 kB	-	-
CDN Bundle	26.89 kB	-	-
CDN Bundle (incl. Tracing)	41.8 kB	+0.05%	+19 B 🔺
CDN Bundle (incl. Tracing, Replay)	78.32 kB	+0.03%	+18 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	83.79 kB	+0.03%	+20 B 🔺
CDN Bundle - uncompressed	78.84 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	124 kB	+0.05%	+57 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	240.03 kB	+0.03%	+57 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	252.79 kB	+0.03%	+57 B 🔺
@sentry/nextjs (client)	45.33 kB	+0.04%	+17 B 🔺
@sentry/sveltekit (client)	41.63 kB	+0.05%	+20 B 🔺
@sentry/node-core	50.76 kB	-	-
@sentry/node	157.84 kB	+0.01%	+1 B 🔺
@sentry/node - without tracing	92.64 kB	-	-
@sentry/aws-serverless	106.4 kB	-0.01%	-3 B 🔽

View base workflow run

[github-actions]

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario	Requests/s	% of Baseline	Prev. Requests/s	Change %
GET Baseline	8,832	-	8,762	+1%
GET With Sentry	1,351	15%	1,394	-3%
GET With Sentry (error only)	6,114	69%	6,136	-0%
POST Baseline	1,200	-	1,200	-
POST With Sentry	506	42%	542	-7%
POST With Sentry (error only)	1,046	87%	1,062	-2%
MYSQL Baseline	3,288	-	3,361	-2%
MYSQL With Sentry	480	15%	476	+1%
MYSQL With Sentry (error only)	2,758	84%	2,740	+1%

View base workflow run

[cursor]

Bug: Incorrect Timeout Assignment Breaks Cancellation

In _restartChildSpanTimeout, the timeout ID is assigned to _idleTimeoutID instead of _childSpanTimeoutID. This causes the child span timeout to overwrite the idle timeout variable, preventing _cancelIdleTimeout from properly canceling the idle timeout and potentially causing incorrect timeout behavior when both timeouts are active.

packages/core/src/tracing/idleSpan.ts#L242-L250

sentry-javascript/packages/core/src/tracing/idleSpan.ts

Lines 242 to 250 in 307b0a2

	function _restartChildSpanTimeout(endTimestamp?: number): void {
	_cancelChildSpanTimeout();
	_idleTimeoutID = setTimeout(() => {
	if (!_finished && _autoFinishAllowed) {
	_finishReason = FINISH_REASON_HEARTBEAT_FAILED;
	span.end(endTimestamp);
	}
	}, childSpanTimeout);
	}

 

---