Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 12, 2025

WIP, Based on #18165

  • Unify attribute -> typed attribute conversion
  • Logs can now have array attributes
  • Apply scope attributes to logs

TBD:

  • permitting units requires extending the Log.attributes type to a similar object that users can pass into scope.setAttribute(s) to define units. I'd rather do this in a follow-up PR.

closes #18159

@Lms24 Lms24 changed the base branch from develop to lms/feat-core-scope-setAttributes November 12, 2025 11:46
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.84 kB +0.98% +241 B 🔺
@sentry/browser - with treeshaking flags 23.33 kB +1.03% +237 B 🔺
@sentry/browser (incl. Tracing) 41.47 kB +0.59% +240 B 🔺
@sentry/browser (incl. Tracing, Profiling) 45.75 kB +0.54% +242 B 🔺
@sentry/browser (incl. Tracing, Replay) 79.95 kB +0.32% +248 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.61 kB +0.34% +234 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 84.62 kB +0.27% +223 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 96.8 kB +0.25% +237 B 🔺
@sentry/browser (incl. Feedback) 41.51 kB +0.58% +239 B 🔺
@sentry/browser (incl. sendFeedback) 29.51 kB +0.82% +240 B 🔺
@sentry/browser (incl. FeedbackAsync) 34.43 kB +0.7% +237 B 🔺
@sentry/react 26.52 kB +0.89% +232 B 🔺
@sentry/react (incl. Tracing) 43.44 kB +0.57% +245 B 🔺
@sentry/vue 29.32 kB +0.81% +235 B 🔺
@sentry/vue (incl. Tracing) 43.25 kB +0.57% +241 B 🔺
@sentry/svelte 24.85 kB +0.98% +240 B 🔺
CDN Bundle 27.06 kB +0.61% +164 B 🔺
CDN Bundle (incl. Tracing) 42.01 kB +0.55% +226 B 🔺
CDN Bundle (incl. Tracing, Replay) 78.52 kB +0.29% +221 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 84.01 kB +0.28% +228 B 🔺
CDN Bundle - uncompressed 79.81 kB +1.21% +947 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 124.9 kB +0.77% +943 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 240.94 kB +0.4% +943 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 253.7 kB +0.38% +943 B 🔺
@sentry/nextjs (client) 45.57 kB +0.56% +253 B 🔺
@sentry/sveltekit (client) 41.86 kB +0.57% +237 B 🔺
@sentry/node-core 51 kB +0.47% +238 B 🔺
@sentry/node 158.09 kB +0.16% +237 B 🔺
@sentry/node - without tracing 92.88 kB +0.26% +233 B 🔺
@sentry/aws-serverless 106.65 kB +0.23% +244 B 🔺

View base workflow run

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,468 - 8,690 -3%
GET With Sentry 1,292 15% 1,397 -8%
GET With Sentry (error only) 5,974 71% 6,120 -2%
POST Baseline 1,173 - 1,213 -3%
POST With Sentry 520 44% 561 -7%
POST With Sentry (error only) 1,030 88% 1,072 -4%
MYSQL Baseline 3,196 - 3,363 -5%
MYSQL With Sentry 389 12% 482 -19%
MYSQL With Sentry (error only) 2,677 84% 2,713 -1%

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants