breadcrumbs: fix prop bleed

JonasBa · JonasBa · commit 6188473b7486 · 2025-11-07T13:36:39.000-08:00
diff --git a/static/app/components/breadcrumbs.tsx b/static/app/components/breadcrumbs.tsx
@@ -115,9 +115,10 @@ interface BreadcrumbLinkProps extends LinkProps {
 }
 
 function BreadcrumbLink(props: BreadcrumbLinkProps) {
-  if (props.preservePageFilters) {
-    return <GlobalSelectionLink {...props} />;
+  const {preservePageFilters, ...rest} = props;
+  if (preservePageFilters) {
+    return <GlobalSelectionLink {...rest} />;
   }
 
-  return <Link {...props} />;
+  return <Link {...rest} />;
 }

Original file line number	Diff line number	Diff line change
`@@ -115,9 +115,10 @@ interface BreadcrumbLinkProps extends LinkProps {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`function BreadcrumbLink(props: BreadcrumbLinkProps) {`
`118`		`- if (props.preservePageFilters) {`
`119`		`- return <GlobalSelectionLink {...props} />;`
	`118`	`+ const {preservePageFilters, ...rest} = props;`
	`119`	`+ if (preservePageFilters) {`
	`120`	`+ return <GlobalSelectionLink {...rest} />;`
`120`	`121`	`}`
`121`	`122`
`122`		`- return <Link {...props} />;`
	`123`	`+ return <Link {...rest} />;`
`123`	`124`	`}`