Merge pull request #654 from GitCredentialManager/bring-oauth-into-the-light

Make Azure Repos OAuth non-experimental

Author: vtbassmatt

README.md

@@ -239,11 +239,11 @@ See detailed information [here](https://aka.ms/gcm/httpproxy).
 - [Credential stores](docs/credstores.md)
 - [Architectural overview](docs/architecture.md)
 - [Host provider specification](docs/hostprovider.md)
+- [Azure Repos OAuth tokens](docs/azrepos-users-and-tokens.md)
 
 ## Experimental Features
 
 - [Windows broker (experimental)](docs/windows-broker.md)
-- [Azure Repos OAuth tokens (experimental)](docs/azrepos-users-and-tokens.md)
 
 ## Contributing
 

docs/azrepos-users-and-tokens.md

@@ -5,11 +5,11 @@
 The Azure Repos host provider supports creating multiple types of credential:
 
 - Azure DevOps personal access tokens
-- Microsoft identity OAuth tokens (experimental)
+- Microsoft identity OAuth tokens
 
 To select which type of credential the Azure Repos host provider will create
-and use, you can set the [`credential.azreposCredentialType`](configuration.md#credentialazreposcredentialtype-experimental)
-configuration entry (or [`GCM_AZREPOS_CREDENTIALTYPE`](environment.md#GCM_AZREPOS_CREDENTIALTYPE-experimental)
+and use, you can set the [`credential.azreposCredentialType`](configuration.md#credentialazreposcredentialtype)
+configuration entry (or [`GCM_AZREPOS_CREDENTIALTYPE`](environment.md#GCM_AZREPOS_CREDENTIALTYPE)
 environment variable).
 
 ### Azure DevOps personal access tokens
@@ -24,7 +24,7 @@ PATs have a limited lifetime and new tokens must be created once they expire. In
 Git Credential Manager, when a PAT expired (or was manually revoked) this
 resulted in a new authentication prompt.
 
-### Microsoft identity OAuth tokens (experimental)
+### Microsoft identity OAuth tokens
 
 "Microsoft identity OAuth token" is the generic term for OAuth-based access
 tokens issued by Azure Active Directory for either Work and School Accounts

docs/configuration.md

@@ -508,7 +508,7 @@ Credential: "git:https://bob@github.com/example/myrepo" (user = bob)
 
 ---
 
-### credential.azreposCredentialType _(experimental)_
+### credential.azreposCredentialType
 
 Specify the type of credential the Azure Repos host provider should return.
 
@@ -527,4 +527,4 @@ More information about Azure Access tokens can be found [here](azrepos-azuretoke
 git config --global credential.azreposCredentialType oauth
 ```
 
-**Also see: [GCM_AZREPOS_CREDENTIALTYPE](environment.md#GCM_AZREPOS_CREDENTIALTYPE-experimental)**
+**Also see: [GCM_AZREPOS_CREDENTIALTYPE](environment.md#GCM_AZREPOS_CREDENTIALTYPE)**

docs/environment.md

@@ -670,7 +670,7 @@ export GCM_MSAUTH_USEBROKER="false"
 
 ---
 
-### GCM_AZREPOS_CREDENTIALTYPE _(experimental)_
+### GCM_AZREPOS_CREDENTIALTYPE
 
 Specify the type of credential the Azure Repos host provider should return.
 
@@ -695,4 +695,4 @@ SET GCM_AZREPOS_CREDENTIALTYPE="oauth"
 export GCM_AZREPOS_CREDENTIALTYPE="oauth"
 ```
 
-**Also see: [credential.azreposCredentialType](configuration.md#azreposcredentialtype-experimental)**
+**Also see: [credential.azreposCredentialType](configuration.md#azreposcredentialtype)**

docs/usage.md

@@ -31,7 +31,7 @@ Set your user-level Git configuration (`~/.gitconfig`) to use GCM. If you pass
 `--system` to these commands, they act on the system-level Git configuration
 (`/etc/gitconfig`) instead.
 
-### azure-repos (experimental)
+### azure-repos
 
 Interact with the Azure Repos host provider to bind/unbind user accounts to Azure DevOps
 organizations or specific remote URLs, and manage the authentication authority cache.

src/shared/Microsoft.AzureRepos/AzureReposHostProvider.cs

@@ -389,7 +389,7 @@ private static string GetAccountNameForCredentialQuery(InputArguments input)
         /// <returns>True if Personal Access Tokens should be used, false otherwise.</returns>
         private bool UsePersonalAccessTokens()
         {
-            // Default to using PATs whilst the Azure AT functionality is being tested
+            // Default to using PATs
             const bool defaultValue = true;
 
             if (_context.Settings.TryGetSetting(
@@ -410,7 +410,7 @@ private bool UsePersonalAccessTokens()
 
                     default:
                         _context.Streams.Error.WriteLine(
-                            $"warning: unknown Azure Repos credential type '{valueStr}' - using default option");
+                            $"warning: unknown Azure Repos credential type '{valueStr}' - using PATs");
                         return defaultValue;
                 }
             }