fix menu config & test case

Author: arzzen

git_py_stats/config.py

@@ -120,6 +120,8 @@ def get_config() -> Dict[str, Union[str, int]]:
     menu_theme: Optional[str] = os.environ.get("_MENU_THEME")
     if menu_theme == "legacy":
         config["menu_theme"] = "legacy"
+    elif menu_theme == "none":
+        config["menu_theme"] = "none"
     else:
         config["menu_theme"] = ""
 

git_py_stats/menu.py

@@ -39,7 +39,7 @@ def interactive_menu(config: Dict[str, Union[str, int]]) -> str:
         NUMS = BOLD
         HELP_TXT = ""
         EXIT_TXT = BOLD
-        NORMAL = "" 
+        NORMAL = ""
     else:
         TITLES = f"{BOLD}{CYAN}"
         TEXT = f"{NORMAL}{WHITE}"

git_py_stats/tests/test_menu.py

@@ -27,6 +27,7 @@ def setUp(self):
         self.config_legacy = {"menu_theme": "legacy"}  # Legacy theme
         self.config_none = {"menu_theme": "none"}  # Alternate colorless theme alias
 
+    # Test cases for default theme
     @patch("builtins.input", return_value="1")
     @patch("sys.stdout", new_callable=StringIO)
     def test_default_theme_option_1(self, mock_stdout, mock_input):
@@ -77,23 +78,11 @@ def test_default_theme_invalid_input(self, mock_stdout, mock_input):
         output = strip_ansi_codes(mock_stdout.getvalue())
         self.assertIn("Generate:", output)
 
-    @patch("builtins.input", return_value="1")
-    @patch("sys.stdout", new_callable=StringIO)
-    def test_legacy_theme_option_1(self, mock_stdout, mock_input):
-        """
-        Test the interactive_menu with legacy theme and user selects option '1'.
-        """
-        choice = interactive_menu(self.config_legacy)
-        self.assertEqual(choice, "1")
-        output = strip_ansi_codes(mock_stdout.getvalue())
-        self.assertIn("Generate:", output)
-        self.assertIn("1) Contribution stats (by author)", output)
-
     @patch("builtins.input", return_value="3")
     @patch("sys.stdout", new_callable=StringIO)
     def test_none_theme_option_3(self, mock_stdout, mock_input):
         """
-        Test the interactive_menu with 'none' theme (alias for colorless) and user selects option '3'.
+        Test the interactive_menu with 'none' theme and user selects option '3'.
         """
         choice = interactive_menu(self.config_none)
         self.assertEqual(choice, "3")
@@ -103,41 +92,43 @@ def test_none_theme_option_3(self, mock_stdout, mock_input):
         self.assertNotIn("\033[36m", output)
         self.assertIn("\033[1m", output)
 
-    @patch("builtins.input", return_value="22")
+    @patch("builtins.input", return_value="1")
     @patch("sys.stdout", new_callable=StringIO)
-    def test_default_theme_option_22(self, mock_stdout, mock_input):
+    def test_none_theme_option_1(self, mock_stdout, mock_input):
         """
-        Test the interactive_menu with default theme and user selects option '22'.
+        Test the interactive_menu with 'none' theme and user selects option '1'.
         """
-        choice = interactive_menu(self.config_default)
-        self.assertEqual(choice, "22")
-        output = strip_ansi_codes(mock_stdout.getvalue())
-        self.assertIn("Suggest:", output)
-        self.assertIn("22) Code reviewers (based on git history)", output)
+        choice = interactive_menu(self.config_none)
+        self.assertEqual(choice, "1")
+        output = mock_stdout.getvalue()
+        self.assertNotIn("\033[31m", output)
+        self.assertNotIn("\033[33m", output)
+        self.assertNotIn("\033[36m", output)
+        self.assertIn("\033[1m", output)
 
     @patch("builtins.input", return_value="")
     @patch("sys.stdout", new_callable=StringIO)
-    def test_default_theme_exit(self, mock_stdout, mock_input):
+    def test_none_theme_exit(self, mock_stdout, mock_input):
         """
-        Test the interactive_menu with default theme and user presses Enter to exit.
+        Test the interactive_menu with none theme and user presses Enter to exit.
         """
-        choice = interactive_menu(self.config_default)
+        choice = interactive_menu(self.config_none)
         self.assertEqual(choice, "")
         output = strip_ansi_codes(mock_stdout.getvalue())
         self.assertIn("press Enter to exit", output)
 
     @patch("builtins.input", return_value="invalid")
     @patch("sys.stdout", new_callable=StringIO)
-    def test_default_theme_invalid_input(self, mock_stdout, mock_input):
+    def test_none_theme_invalid_input(self, mock_stdout, mock_input):
         """
-        Test the interactive_menu with default theme and user enters an invalid option.
+        Test the interactive_menu with none theme and user enters an invalid option.
         """
-        choice = interactive_menu(self.config_default)
+        choice = interactive_menu(self.config_none)
         self.assertEqual(choice, "invalid")
-        # Since interactive_menu doesn't print 'Invalid selection', we don't assert that here.
         output = strip_ansi_codes(mock_stdout.getvalue())
         self.assertIn("Generate:", output)
 
+    # Test cases for legacy theme
     @patch("builtins.input", return_value="1")
     @patch("sys.stdout", new_callable=StringIO)
     def test_legacy_theme_option_1(self, mock_stdout, mock_input):
@@ -183,6 +174,7 @@ def test_legacy_theme_invalid_input(self, mock_stdout, mock_input):
         output = strip_ansi_codes(mock_stdout.getvalue())
         self.assertIn("Generate:", output)
 
+    # Test cases for handling multiple inputs and edge cases
     @patch("builtins.input", side_effect=["1", ""])
     @patch("sys.stdout", new_callable=StringIO)
     def test_multiple_inputs(self, mock_stdout, mock_input):
@@ -207,6 +199,7 @@ def test_input_with_whitespace(self, mock_stdout, mock_input):
         output = strip_ansi_codes(mock_stdout.getvalue())
         self.assertIn("5) My daily status", output)
 
+    # Test cases for handling exit commands
     @patch("builtins.input", return_value="QUIT")
     @patch("sys.stdout", new_callable=StringIO)
     def test_input_quit(self, mock_stdout, mock_input):
@@ -251,5 +244,6 @@ def test_keyboard_interrupt(self, mock_stdout, mock_input):
         output = strip_ansi_codes(mock_stdout.getvalue())
         self.assertIn("Generate:", output)
 
+
 if __name__ == "__main__":
     unittest.main()