Process improvements (#1316)

* Add default linters and bump golangci-lint version

* More aggressive policy

Author: JoannaaKL

.github/workflows/close-inactive-issues.yml

@@ -7,8 +7,8 @@ jobs:
   close-issues:
     runs-on: ubuntu-latest
     env:
-      PR_DAYS_BEFORE_STALE: 60
-      PR_DAYS_BEFORE_CLOSE: 120
+      PR_DAYS_BEFORE_STALE: 30
+      PR_DAYS_BEFORE_CLOSE: 60
       PR_STALE_LABEL: stale
     permissions:
       issues: write
@@ -21,8 +21,8 @@ jobs:
           stale-issue-label: ${{ env.PR_STALE_LABEL }}
           stale-issue-message: "This issue is stale because it has been open for ${{ env.PR_DAYS_BEFORE_STALE }} days with no activity. Leave a comment to avoid closing this issue in ${{ env.PR_DAYS_BEFORE_CLOSE }} days."
           close-issue-message: "This issue was closed because it has been inactive for ${{ env.PR_DAYS_BEFORE_CLOSE }} days since being marked as stale."
-          days-before-pr-stale: -1
-          days-before-pr-close: -1
+          days-before-pr-stale: ${{ env.PR_DAYS_BEFORE_STALE }}
+          days-before-pr-close: ${{ env.PR_DAYS_BEFORE_STALE }}
           # Start with the oldest items first
           ascending: true
           repo-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/lint.yml

@@ -20,4 +20,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.1
+          version: v2.5

.golangci.yml

@@ -11,6 +11,11 @@ linters:
     - misspell
     - nakedret
     - revive
+    - errcheck
+    - staticcheck
+    - govet
+    - ineffassign
+    - unused
   exclusions:
     generated: lax
     presets:

script/lint

@@ -5,7 +5,7 @@ gofmt -s -w .
 
 BINDIR="$(git rev-parse --show-toplevel)"/bin
 BINARY=$BINDIR/golangci-lint
-GOLANGCI_LINT_VERSION=v2.2.1
+GOLANGCI_LINT_VERSION=v2.5.0
 
 if [ ! -f "$BINARY" ]; then
     curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s "$GOLANGCI_LINT_VERSION"