fix: add try/catch to lang getter

Author: francinelucca

src/relative-time-element.ts

@@ -82,11 +82,13 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
   #updating: false | Promise<void> = false
 
   get #lang() {
-    return (
-      this.closest('[lang]')?.getAttribute('lang') ||
-      this.ownerDocument.documentElement.getAttribute('lang') ||
-      'default'
-    )
+    const lang = this.closest('[lang]')?.getAttribute('lang') ||
+      this.ownerDocument.documentElement.getAttribute('lang')
+    try {
+      return new Intl.Locale(lang ?? '').toString()
+    } catch {
+      return 'default'
+    }
   }
 
   #renderRoot: Node = this.shadowRoot ? this.shadowRoot : this.attachShadow ? this.attachShadow({mode: 'open'}) : this
@@ -120,27 +122,14 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
   //
   // Returns a formatted time String.
   #getFormattedTitle(date: Date): string | undefined {
-    let dateTimeFormat
-    try {
-      dateTimeFormat = new Intl.DateTimeFormat(this.#lang, {
-        day: 'numeric',
-        month: 'short',
-        year: 'numeric',
-        hour: 'numeric',
-        minute: '2-digit',
-        timeZoneName: 'short',
-      })
-    } catch (_e) {
-      dateTimeFormat = new Intl.DateTimeFormat('default', {
-        day: 'numeric',
-        month: 'short',
-        year: 'numeric',
-        hour: 'numeric',
-        minute: '2-digit',
-        timeZoneName: 'short',
-      })
-    }
-    return dateTimeFormat.format(date)
+    return new Intl.DateTimeFormat(this.#lang, {
+      day: 'numeric',
+      month: 'short',
+      year: 'numeric',
+      hour: 'numeric',
+      minute: '2-digit',
+      timeZoneName: 'short',
+    }).format(date)
   }
 
   #resolveFormat(duration: Duration): ResolvedFormat {
@@ -185,19 +174,10 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
   }
 
   #getRelativeFormat(duration: Duration): string {
-    let relativeFormat
-
-    try {
-      relativeFormat = new Intl.RelativeTimeFormat(this.#lang, {
-        numeric: 'auto',
-        style: this.formatStyle,
-      })
-    } catch (_e) {
-      relativeFormat = new Intl.RelativeTimeFormat('default', {
-        numeric: 'auto',
-        style: this.formatStyle,
-      })
-    }
+    const relativeFormat = new Intl.RelativeTimeFormat(this.#lang, {
+      numeric: 'auto',
+      style: this.formatStyle,
+    })
 
     const tense = this.tense
     if (tense === 'future' && duration.sign !== 1) duration = emptyDuration
@@ -210,30 +190,16 @@ export class RelativeTimeElement extends HTMLElement implements Intl.DateTimeFor
   }
 
   #getDateTimeFormat(date: Date): string {
-    let formatter
-    try {
-      formatter = new Intl.DateTimeFormat(this.#lang, {
-        second: this.second,
-        minute: this.minute,
-        hour: this.hour,
-        weekday: this.weekday,
-        day: this.day,
-        month: this.month,
-        year: this.year,
-        timeZoneName: this.timeZoneName,
-      })
-    } catch (_e) {
-      formatter = new Intl.DateTimeFormat('default', {
-        second: this.second,
-        minute: this.minute,
-        hour: this.hour,
-        weekday: this.weekday,
-        day: this.day,
-        month: this.month,
-        year: this.year,
-        timeZoneName: this.timeZoneName,
-      })
-    }
+    const formatter = new Intl.DateTimeFormat(this.#lang, {
+      second: this.second,
+      minute: this.minute,
+      hour: this.hour,
+      weekday: this.weekday,
+      day: this.day,
+      month: this.month,
+      year: this.year,
+      timeZoneName: this.timeZoneName,
+    })
     return `${this.prefix} ${formatter.format(date)}`.trim()
   }