Skip to content

Commit b6bf184

Browse files
asgerfCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 438c0ba commit b6bf184

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

extensions/ql-vscode/src/compare-performance/compare-performance-view.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ export class ComparePerformanceView extends AbstractWebview<
5151
to: CompletedLocalQueryInfo,
5252
) {
5353
const fromJsonLog =
54-
from === undefined ? "" : from?.evaluatorLogPaths?.jsonSummary;
55-
const toJsonLog = to?.evaluatorLogPaths?.jsonSummary;
54+
from === undefined ? "" : from.evaluatorLogPaths?.jsonSummary;
55+
const toJsonLog = to.evaluatorLogPaths?.jsonSummary;
5656

5757
if (fromJsonLog === undefined || toJsonLog === undefined) {
5858
return extLogger.showWarningMessage(
59-
`Cannot compare performance as the structured logs are missing. Did they queries complete normally?`,
59+
`Cannot compare performance as the structured logs are missing. Did the queries complete normally?`,
6060
);
6161
}
6262
await extLogger.log(
@@ -106,7 +106,7 @@ export class ComparePerformanceView extends AbstractWebview<
106106

107107
const fromName =
108108
from === undefined ? "" : this.labelProvider.getLabel(from);
109-
const toName = to === undefined ? "" : this.labelProvider.getLabel(to);
109+
const toName = this.labelProvider.getLabel(to);
110110

111111
await this.postMessage({
112112
t: "setPerformanceComparison",

0 commit comments

Comments
 (0)