refactor: improve error logging with log.exception()

Author: akosyakov

src/gitpod/lib/disposables.py

@@ -1,6 +1,8 @@
 from typing import Any, Callable, List
 import logging
 
+log = logging.getLogger(__name__)
+
 class Disposables:
     """A utility class to manage cleanup actions (disposables) in a LIFO order.
     
@@ -44,5 +46,5 @@ def cleanup(self) -> None:
         for action in reversed(self._actions):
             try:
                 action()
-            except BaseException as e:
-                logging.warning(f"Cleanup action failed: {e}")
+            except BaseException:
+                log.exception("cleanup action failed")

src/gitpod/lib/environment.py

@@ -43,10 +43,10 @@ async def _update_environment(self):
             for listener in list(self._listeners):
                 try:
                     listener(env)
-                except Exception as e:
-                    log.error(f"Error in environment listener: {e}")
-        except BaseException as e:
-            log.error(f"Error in environment update: {e}")
+                except Exception:
+                    log.exception("failed to call listener")
+        except BaseException:
+            log.exception("failed to update environment")
 
     async def _start_update_loop(self):
         """Background coroutine that maintains the event stream"""
@@ -86,8 +86,8 @@ async def _start_update_loop(self):
             except BaseException as e:
                 if self._should_stop or isinstance(e, asyncio.CancelledError):
                     break
-                    
-                log.warning(f"Error in event stream, retrying in {retry_delay}s: {e}")
+                
+                log.exception("error in event stream, retrying in %s seconds", retry_delay)
                 await asyncio.sleep(retry_delay)
                 retry_delay = min(retry_delay * 2, max_delay)