build(deps): bump golang.org/x/tools from 0.38.0 to 0.39.0 (#6193)

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>

Author: dependabot[bot]

.golangci.next.reference.yml

@@ -2137,6 +2137,8 @@ linters:
         - newexpr
         # Suggest replacing omitempty with omitzero for struct fields.
         - omitzero
+        # Remove obsolete //+build comments.
+        - plusbuild
         # Replace 3-clause for loops with for-range over integers.
         - rangeint
         # Replace reflect.TypeOf(x) with TypeFor[T]().
@@ -2147,6 +2149,8 @@ linters:
         - slicessort
         # Use iterators instead of Len/At-style APIs.
         - stditerators
+        # Replace strings.Index etc. with strings.Cut.
+        - stringscut
         # Replace HasPrefix/TrimPrefix with CutPrefix.
         - stringscutprefix
         # Replace ranging over Split/Fields with SplitSeq/FieldsSeq.

go.mod

@@ -139,7 +139,7 @@ require (
 	golang.org/x/mod v0.30.0
 	golang.org/x/sync v0.18.0
 	golang.org/x/sys v0.38.0
-	golang.org/x/tools v0.38.0
+	golang.org/x/tools v0.39.0
 	gopkg.in/yaml.v3 v3.0.1
 	honnef.co/go/tools v0.6.1
 	mvdan.cc/gofumpt v0.9.2

go.sum

@@ -717,11 +717,13 @@
         "minmax",
         "newexpr",
         "omitzero",
+        "plusbuild",
         "rangeint",
         "reflecttypefor",
         "slicescontains",
         "slicessort",
         "stditerators",
+        "stringscut",
         "stringscutprefix",
         "stringsseq",
         "stringsbuilder",

jsonschema/golangci.next.jsonschema.json

@@ -2,13 +2,20 @@ package contextcheck
 
 import (
 	"github.com/kkHAIKE/contextcheck"
+	"golang.org/x/tools/go/analysis/passes/ctrlflow"
+	"golang.org/x/tools/go/analysis/passes/inspect"
 
 	"github.com/golangci/golangci-lint/v2/pkg/goanalysis"
 	"github.com/golangci/golangci-lint/v2/pkg/lint/linter"
 )
 
 func New() *goanalysis.Linter {
 	analyzer := contextcheck.NewAnalyzer(contextcheck.Configuration{})
+	// TODO(ldez) there is a problem with this linter:
+	// I think the problem related to facts.
+	// The BuildSSA pass has been changed inside (0.39.0):
+	// https://github.com/golang/tools/commit/b74c09864920a69a4d2f6ef0ecb4f9cff226893a
+	analyzer.Requires = append(analyzer.Requires, ctrlflow.Analyzer, inspect.Analyzer)
 
 	return goanalysis.
 		NewLinterFromAnalyzer(analyzer).

pkg/golinters/contextcheck/contextcheck.go

@@ -17,7 +17,7 @@ var (
 	_ = reflect.TypeOf((*error)(nil))     // want "reflect.TypeOf call can be simplified using TypeFor"
 	_ = reflect.TypeOf(io.Reader(nil))    // nope (likely a mistake)
 	_ = reflect.TypeOf((*io.Reader)(nil)) // want "reflect.TypeOf call can be simplified using TypeFor"
-	_ = reflect.TypeOf(*new(time.Time))   // nope (false negative of noEffects)
+	_ = reflect.TypeOf(*new(time.Time))   // want "reflect.TypeOf call can be simplified using TypeFor"
 	_ = reflect.TypeOf(time.Time{})       // want "reflect.TypeOf call can be simplified using TypeFor"
 	_ = reflect.TypeOf(time.Duration(0))  // want "reflect.TypeOf call can be simplified using TypeFor"
 )

pkg/golinters/modernize/testdata/fix/in/reflecttypefor.go

@@ -52,7 +52,7 @@ func assignTrueBreak(slice []int, needle int) {
 	print(found)
 }
 
-func assignFalseBreak(slice []int, needle int) { // TODO: treat this specially like booleanTrue
+func assignFalseBreak(slice []int, needle int) {
 	found := true
 	for _, elem := range slice { // want "Loop can be simplified using slices.Contains"
 		if elem == needle {

pkg/golinters/modernize/testdata/fix/in/slicescontains.go

@@ -5,37 +5,28 @@ package forvar
 func _(m map[int]int, s []int) {
 	// changed
 	for i := range s {
-		// want "copying variable is unneeded"
 		go f(i)
 	}
 	for _, v := range s {
-		// want "copying variable is unneeded"
 		go f(v)
 	}
 	for k, v := range m {
-		// want "copying variable is unneeded"
-		// want "copying variable is unneeded"
 		go f(k)
 		go f(v)
 	}
 	for k, v := range m {
-		// want "copying variable is unneeded"
-		// want "copying variable is unneeded"
 		go f(k)
 		go f(v)
 	}
 	for k, v := range m {
-		// want "copying variable is unneeded"
 		go f(k)
 		go f(v)
 	}
 	for k, v := range m {
-		// want "copying variable is unneeded"
 		go f(k)
 		go f(v)
 	}
 	for i := range s {
-		/* hi */ // want "copying variable is unneeded"
 		go f(i)
 	}
 	// nope

pkg/golinters/modernize/testdata/fix/out/forvar.go

@@ -17,7 +17,7 @@ var (
 	_ = reflect.TypeFor[*error]()        // want "reflect.TypeOf call can be simplified using TypeFor"
 	_ = reflect.TypeOf(io.Reader(nil))   // nope (likely a mistake)
 	_ = reflect.TypeFor[*io.Reader]()    // want "reflect.TypeOf call can be simplified using TypeFor"
-	_ = reflect.TypeOf(*new(time.Time))  // nope (false negative of noEffects)
+	_ = reflect.TypeFor[time.Time]()     // want "reflect.TypeOf call can be simplified using TypeFor"
 	_ = reflect.TypeFor[time.Time]()     // want "reflect.TypeOf call can be simplified using TypeFor"
 	_ = reflect.TypeFor[time.Duration]() // want "reflect.TypeOf call can be simplified using TypeFor"
 )

pkg/golinters/modernize/testdata/fix/out/reflecttypefor.go

@@ -38,11 +38,8 @@ func assignTrueBreak(slice []int, needle int) {
 	print(found)
 }
 
-func assignFalseBreak(slice []int, needle int) { // TODO: treat this specially like booleanTrue
-	found := true
-	if slices.Contains(slice, needle) {
-		found = false
-	}
+func assignFalseBreak(slice []int, needle int) {
+	found := !slices.Contains(slice, needle)
 	print(found)
 }