clean

Author: goldst

blocks/card/CardAbstract.js

@@ -106,6 +106,11 @@ export default class cardAbstract {
         this._cm.mousemoveEventShadow();
     }
 
+    /**
+     * runs doEvent on both CardTransformable and CardMouseShadowed
+     * @todo that's a bad description. change
+     * @param {event} event
+     */
     doEvent(event) {
         this._ct.doEvent(event);
         this._cm.doEvent(event);

blocks/card/card.css

@@ -36,8 +36,8 @@
 }
 
 .card:hover {
-    transition: transform 0.5s;
     transform: scale(var(--_hover-scale));
+    transition: transform 0.5s;
     z-index: 100;
 }
 

blocks/card/card.js

@@ -12,10 +12,10 @@ window.addEventListener('load', () => {
     CP.mousemoveEvent();
     CM.mousemoveEvent();
     C.mousemoveEvent();
-    
+
     window.addEventListener('mousemove', (e) => {
         CP.doEvent(e);
         CM.doEvent(e);
         C.doEvent(e);
-    })
+    });
 });

index.html

@@ -33,20 +33,6 @@ <h1 class="card__title card--main__title">
                             <span class="card__title main-card__birth">
                                 01.01.1999
                             </span>
-                            <script>
-                                function toMail(encrypted) {
-                                    let decrypted = "";
-                                    for(let i = 0; i < encrypted.length; i++) {
-                                        if(encrypted.charCodeAt(i) > 122) {
-                                            decrypted += String.fromCharCode(encrypted.charCodeAt(i+1) - 56561);
-                                            i++;
-                                        } else {
-                                            decrypted += encrypted.charAt(i);
-                                        }
-                                    }
-                                    window.open("mailto:" + decrypted, "_self");
-                                }
-                            </script>
                             <div class="card--main__social-links">
                                 <a href="https://github.com/goldst" class="card--main__social-link card--main__social-link--github main-card__button main-card__button--github button button--s">
                                     GitHub
@@ -218,5 +204,6 @@ <h3 class="card__title project-card__title">
         </ul>
     </footer>
     <script src="blocks/index.js" type="module"></script>
+    <script src="js/safety/safety.js"></script>
 </body>
 </html>

js/eventControl/EventController.js

@@ -214,10 +214,15 @@ export default class EventController {
         this.eventControlElements
             .filter(ece => ece.domElement.matches(additionalFilter))
             .forEach(ece => {
+                /**
+                 * Function that will be run on events, when calling
+                 * doEvent or on events of eventType
+                 * @param {event} event
+                 */
                 const run = (event) => {
                     this._modify(event, ece, modificationFunction);
                     postFunction.call(this, event, ece);
-                }
+                };
 
                 if(eventType !== null) {
                     document.addEventListener(eventType, run);
@@ -227,11 +232,18 @@ export default class EventController {
             });
     }
 
+    /**
+     * runs modification functions and postfunctions for all
+     * EventControlElements, if they have previously been passed via
+     * listenToChangeCss
+     * @param {event} event
+     * @returns {void}
+     */
     doEvent(event) {
         this.eventControlElements
             .forEach(ece => {
                 // only if doEvent was set by listenToChangeCss
-                if(ece.doEvent !== undefined) { 
+                if(ece.doEvent !== undefined) {
                     ece.doEvent(event);
                 }
             });

js/safety/safety.js

@@ -0,0 +1,20 @@
+/**
+ * takes an encrypted mail address, written in lower-case mathematical
+ * double struck letters (𝕒-𝕫) and "normal" characters (all characters
+ * with character codes under 122), converts it to a real mail address
+ * and opens the mailto link if possible
+ * @param {string} encrypted
+ * @returns {void}
+ */
+function toMail(encrypted) {
+    let decrypted = "";
+    for(let i = 0; i < encrypted.length; i++) {
+        if(encrypted.charCodeAt(i) > 122) {
+            decrypted += String.fromCharCode(encrypted.charCodeAt(i+1) - 56561);
+            i++;
+        } else {
+            decrypted += encrypted.charAt(i);
+        }
+    }
+    window.open("mailto:" + decrypted, "_self");
+}