-
Notifications
You must be signed in to change notification settings - Fork 37
refactor: use 'use' instead of 'namespace' in routes/web.php (#340) #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: use 'use' instead of 'namespace' in routes/web.php (#340) #475
Conversation
WalkthroughThe pull request refactors route definitions in Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes This refactor applies a consistent and repetitive pattern across a single file. While the volume of changes is substantial (many controller imports and route updates), the homogeneity of the pattern (identical syntax transformation applied throughout) significantly reduces review complexity.
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
routes/web.php
Outdated
| use App\Http\Controllers\Admin\User\ShowController as AdminUserShowController; | ||
| use App\Http\Controllers\Admin\User\StoreController as AdminUserStoreController; | ||
| use App\Http\Controllers\Admin\User\UpdateController as AdminUserUpdateController; | ||
| use App\Http\Controllers\Admin\User\DeleteController as AdminUserDeleteController; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nima8FT Hello!
Thanks for your contributions!
Please fix the code style (just run composer cs-fix in shell) and I will merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gomzyakov Hi!
Thanks for the feedback. I’ve run composer fix and updated the code style. The changes are now pushed to this branch.
This PR refactors the routes/web.php file to replace the deprecated Route::namespace() usage with proper 'use' statements at the top of the file.
This aligns the project with modern Laravel standards.
Fix #340