Skip to content

Commit 49cc63d

Browse files
authored
chore: revert "ci: exclude internal/librariangen/** on unrelated checks" (#3960)
Reverts #3953. Due to the change, GitHub Actions stopped running the checks while the checks are still marked as required. Tried this in #3959 (comment). <img width="1742" height="1336" alt="image" src="https://github.com/user-attachments/assets/513fb435-65a9-4841-b3ca-d79a00fe1687" /> The documentation about this GitHub Actions behavior is https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks : > If a workflow is skipped due to [path filtering](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore), [branch filtering](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpull_requestpull_request_targetbranchesbranches-ignore) or a [commit message](https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs), then checks associated with that workflow will remain in a "Pending" state. A pull request that requires those checks to be successful will be blocked from merging. > > If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". For more information, see [Using conditions to control job execution](https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution). I didn't find usages of a file path filter in the condition of a job within a workflow. https://github.com/googleapis/sdk-platform-java/blob/main/.github/workflows/verify_library_generation.yaml#L8 is is a good example how to skip the main job library-generation-unit-tests, by introducing the should-run-library-generation-tests job.
1 parent 2f6c75d commit 49cc63d

File tree

6 files changed

+0
-12
lines changed

6 files changed

+0
-12
lines changed

.github/workflows/ci.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ on:
33
branches:
44
- main
55
pull_request:
6-
paths-ignore:
7-
- 'internal/librariangen/**'
86
name: ci
97
jobs:
108
build:

.github/workflows/dependency_compatibility_test.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ on:
44
pull_request:
55
branches:
66
- 'main'
7-
paths-ignore:
8-
- 'internal/librariangen/**'
97
workflow_dispatch:
108
inputs:
119
dependencies-list:

.github/workflows/hermetic_library_generation.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@
1616
name: Hermetic library generation upon generation config change through pull requests
1717
on:
1818
pull_request:
19-
paths-ignore:
20-
- 'internal/librariangen/**'
2119

2220
env:
2321
REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}

.github/workflows/java_compatibility_check.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
# downstream client libraries before they are released.
1616
on:
1717
pull_request:
18-
paths-ignore:
19-
- 'internal/librariangen/**'
2018
name: Java 8 compatibility check
2119
jobs:
2220
java8-compatibility-check:

.github/workflows/sonar.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ on:
55
- main
66
pull_request:
77
types: [opened, synchronize, reopened]
8-
paths-ignore:
9-
- 'internal/librariangen/**'
108
jobs:
119
build:
1210
name: Build

.github/workflows/verify_library_generation.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
on:
22
pull_request:
3-
paths-ignore:
4-
- 'internal/librariangen/**'
53

64
name: verify_library_generation
75
jobs:

0 commit comments

Comments
 (0)