Remove warning for version missing in catalog

- In more cases, a platform is the appropriate solution to also
  influence versions of transitive dependencies
- We might add the option to use a properties file (#68) which
  makes it even more unclear if versions are expected in the catalog
  or not

Author: jjohannes

src/main/java/org/gradlex/javamodule/dependencies/JavaModuleDependenciesExtension.java

@@ -64,6 +64,7 @@
  * - Define dependencies and dependency constraints by Module Name
  *   using {@link #ga(String)}, {@link #gav(String, String)} or {@link #gav(String)}
  */
+@SuppressWarnings("unused")
 public abstract class JavaModuleDependenciesExtension {
     static final String JAVA_MODULE_DEPENDENCIES = "javaModuleDependencies";
 
@@ -84,16 +85,17 @@ public abstract class JavaModuleDependenciesExtension {
      * name that corresponds to the artifact name and all have the group (e.g. 'com.example.product'), you can
      * register a mapping for all these Modules. and with that allow Gradle to map them correctly even if you
      * publish some of your Modules or use included builds.
-     *
+     * <p>
      * moduleNamePrefixToGroup.put("com.example.product.module.", "com.example.product")
      *
      * @return the mappings from 'Module Name Prefix' to 'group'
      */
     public abstract MapProperty<String, String> getModuleNamePrefixToGroup();
 
     /**
-     * @return If a Version Catalog is used: print a WARN for missing versions (default is 'true')
+     * @return no-op
      */
+    @Deprecated
     public abstract Property<Boolean> getWarnForMissingVersions();
 
     /**
@@ -112,7 +114,6 @@ public abstract class JavaModuleDependenciesExtension {
     public JavaModuleDependenciesExtension(VersionCatalogsExtension versionCatalogs) {
         this.versionCatalogs = versionCatalogs;
         this.moduleInfoCache = getObjects().newInstance(ModuleInfoCache.class);
-        getWarnForMissingVersions().convention(versionCatalogs != null);
         getVersionCatalogName().convention("libs");
         getAnalyseOnly().convention(false);
         getModuleNameToGA().putAll(SharedMappings.mappings);
@@ -208,9 +209,6 @@ public Provider<Dependency> create(String moduleName, SourceSet sourceSetWithMod
                 if (capability != null) {
                     dependency.capabilities(c -> c.requireCapability(capability));
                 }
-                if (!component.containsKey(GAV.VERSION)) {
-                    warnVersionMissing(moduleName, component, moduleInfo.getFilePath());
-                }
                 return dependency;
             } else {
                 getProject().getLogger().lifecycle(
@@ -326,6 +324,7 @@ public void versionsFromConsistentResolution(String... versionsProvidingProjects
         });
         getConfigurations().configureEach(c -> {
             if (c.isCanBeResolved() && !c.isCanBeConsumed() && c != mainRuntimeClasspath) {
+                //noinspection UnstableApiUsage
                 c.shouldResolveConsistentlyWith(mainRuntimeClasspath);
             }
         });
@@ -408,13 +407,6 @@ private <T> Provider<T> errorIfNotFound(Provider<String> moduleName) {
         });
     }
 
-    private void warnVersionMissing(String moduleName, Map<String, Object> ga, File moduleInfoFile) {
-        if (getWarnForMissingVersions().get()) {
-            getProject().getLogger().warn("[WARN] [Java Module Dependencies] No version defined in catalog - " + ga.get(GAV.GROUP) + ":" + ga.get(GAV.ARTIFACT) + " - "
-                    + moduleDebugInfo(moduleName.replace('.', '_'), moduleInfoFile, getProject().getRootDir()));
-        }
-    }
-
     private String moduleDebugInfo(String moduleName, File moduleInfoFile, File rootDir) {
         return moduleName
                 + " (required in "

src/main/java/org/gradlex/javamodule/dependencies/JavaModuleDependenciesPlugin.java

@@ -172,8 +172,8 @@ private void setupReportTasks(Project project, JavaModuleDependenciesExtension j
             t.setGroup(HELP_GROUP);
             t.setDescription("Query repositories for latest stable versions of the used Java Modules");
 
-            t.getPrintForPlatform().convention(javaModuleDependencies.getWarnForMissingVersions().map(b -> !b));
-            t.getPrintForCatalog().convention(javaModuleDependencies.getWarnForMissingVersions());
+            t.getPrintForPlatform().convention(true);
+            t.getPrintForCatalog().convention(false);
         });
     }
 

src/main/java/org/gradlex/javamodule/dependencies/SharedMappings.java

@@ -21,7 +21,7 @@
 import java.util.Map;
 import java.util.Properties;
 
-final class SharedMappings {
+final public class SharedMappings {
     static Map<String, String> mappings = loadModuleNameToGAProperties();
 
     static Map<String, String> loadModuleNameToGAProperties() {

src/test/groovy/org/gradlex/javamodule/dependencies/test/WarningsTest.groovy

@@ -8,33 +8,6 @@ class WarningsTest extends Specification {
     @Delegate
     GradleBuild build = new GradleBuild()
 
-    def "prints warning for version missing in catalog"() {
-        given:
-        file('gradle/libs.versions.toml') << '''
-            [versions]
-            org_apache_xmlbeans = "5.0.1"
-        '''.stripIndent()
-        appBuildFile << '''
-            dependencies.constraints {
-                javaModuleDependencies {
-                    implementation(gav("com.fasterxml.jackson.databind", "2.12.5"))
-                }
-            }
-        '''
-        appModuleInfoFile << '''
-            module org.gradlex.test.app { 
-                requires com.fasterxml.jackson.databind;
-                requires org.apache.xmlbeans;
-            }
-        '''
-
-        when:
-        def result = build()
-
-        then:
-        result.output.contains('[WARN] [Java Module Dependencies] No version defined in catalog - com.fasterxml.jackson.core:jackson-databind - com_fasterxml_jackson_databind (required in app/src/main/java/module-info.java)')
-    }
-
     def "warning for version missing in catalog can be disabled"() {
         given:
         file('gradle/libs.versions.toml') << '''