Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Commit 03322cd

Browse files
authored
Use generic writer in deduplicatingSlice (#522)
1 parent ae6ed84 commit 03322cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/phlaredb/deduplicating_slice.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ type deduplicatingSlice[M Models, K comparable, H Helper[M, K], P schemav1.Persi
3939

4040
file *os.File
4141
cfg *ParquetConfig
42-
writer *parquet.Writer
42+
writer *parquet.GenericWriter[P]
4343

4444
buffer *parquet.Buffer
4545
rowsFlushed int
@@ -66,7 +66,7 @@ func (s *deduplicatingSlice[M, K, H, P]) Init(path string, cfg *ParquetConfig) e
6666
s.file = file
6767

6868
// TODO: Reuse parquet.Writer beyond life time of the head.
69-
s.writer = parquet.NewWriter(file, s.persister.Schema(),
69+
s.writer = parquet.NewGenericWriter[P](file, s.persister.Schema(),
7070
parquet.ColumnPageBuffers(parquet.NewFileBufferPool(os.TempDir(), "phlaredb-parquet-buffers*")),
7171
parquet.CreatedBy("github.com/grafana/phlare/", build.Version, build.Revision),
7272
)

0 commit comments

Comments
 (0)