Merge pull request #363 from grafana/20221025_depend-image-build-on-go-build

Depend on go/bin when building the docker image

Author: simonswine

.github/workflows/test.yml

@@ -123,8 +123,6 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: 1.18.7
-      - name: build binaries
-        run: make go/mod go/bin
       - name: Build image Phlare
         run: make docker-image/phlare/build "BUILDX_ARGS=--cache-from=type=gha --cache-to=type=gha"
 
@@ -163,8 +161,6 @@ jobs:
         uses: actions/setup-go@v2
         with:
           go-version: 1.18.7
-      - name: build binaries
-        run: make go/mod go/bin
       - name: Login to GCR
         uses: docker/login-action@v2
         with:

Makefile

@@ -156,11 +156,11 @@ define deploy
 endef
 
 .PHONY: docker-image/phlare/build
-docker-image/phlare/build:
+docker-image/phlare/build: go/bin
 	$(call docker_buildx,--load)
 
 .PHONY: docker-image/phlare/push
-docker-image/phlare/push:
+docker-image/phlare/push: go/bin
 	$(call docker_buildx,--push)
 
 .PHONY: docker-image/grafana/build