Fixes mapping slice insertion (#479)

cyriltovena · web-flow · commit 43309e449999 · 2023-01-17T13:35:45.000+01:00
diff --git a/pkg/phlaredb/sample_merge.go b/pkg/phlaredb/sample_merge.go
@@ -221,9 +221,9 @@ func (b *singleBlockQuerier) resolvePprofSymbols(ctx context.Context, stacktrace
 		model.A.BuildID = names[stringsIds[model.B.BuildId]]
 	}
 
-	mappingResult := make([]*profile.Mapping, len(mappingIDs))
-	for i, model := range mappingIDs {
-		mappingResult[i] = model.A
+	mappingResult := make([]*profile.Mapping, 0, len(mappingIDs))
+	for _, model := range mappingIDs {
+		mappingResult = append(mappingResult, model.A)
 	}
 
 	for id, model := range stacktraceAggrByID {

Original file line number	Diff line number	Diff line change
`@@ -221,9 +221,9 @@ func (b *singleBlockQuerier) resolvePprofSymbols(ctx context.Context, stacktrace`
`221`	`221`	`model.A.BuildID = names[stringsIds[model.B.BuildId]]`
`222`	`222`	`}`
`223`	`223`
`224`		`- mappingResult := make([]*profile.Mapping, len(mappingIDs))`
`225`		`- for i, model := range mappingIDs {`
`226`		`- mappingResult[i] = model.A`
	`224`	`+ mappingResult := make([]*profile.Mapping, 0, len(mappingIDs))`
	`225`	`+ for _, model := range mappingIDs {`
	`226`	`+ mappingResult = append(mappingResult, model.A)`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`for id, model := range stacktraceAggrByID {`