Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Commit da9ab18

Browse files
authored
Merge pull request #411 from grafana/fix-release-version
Fixes goreleaser version in binary
2 parents 06f6d6d + 98b25cd commit da9ab18

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

.goreleaser.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ builds:
2424
ldflags:
2525
- >
2626
-extldflags "-static" -s -w
27-
-X "github.com/grafana/phlare/pkg/util/build.Branch={{ .Env.GIT_BRANCH }}"
28-
-X "github.com/grafana/phlare/pkg/util/build.Version={{ .Env.IMAGE_TAG }}"
29-
-X "github.com/grafana/phlare/pkg/util/build.Revision={{ .Env.GIT_REVISION }}"
27+
-X "github.com/grafana/phlare/pkg/util/build.Branch={{ .Branch }}"
28+
-X "github.com/grafana/phlare/pkg/util/build.Version={{ .Version }}"
29+
-X "github.com/grafana/phlare/pkg/util/build.Revision={{ .ShortCommit }}"
3030
-X "github.com/grafana/phlare/pkg/util/build.BuildDate={{ .Env.GIT_LAST_COMMIT_DATE }}"
3131
id: phlare
3232
- env:
@@ -36,9 +36,9 @@ builds:
3636
ldflags:
3737
- >
3838
-extldflags "-static" -s -w
39-
-X "github.com/grafana/phlare/pkg/util/build.Branch={{ .Env.GIT_BRANCH }}"
40-
-X "github.com/grafana/phlare/pkg/util/build.Version={{ .Env.IMAGE_TAG }}"
41-
-X "github.com/grafana/phlare/pkg/util/build.Revision={{ .Env.GIT_REVISION }}"
39+
-X "github.com/grafana/phlare/pkg/util/build.Branch={{ .Branch }}"
40+
-X "github.com/grafana/phlare/pkg/util/build.Version={{ .Version }}"
41+
-X "github.com/grafana/phlare/pkg/util/build.Revision={{ .ShortCommit }}"
4242
-X "github.com/grafana/phlare/pkg/util/build.BuildDate={{ .Env.GIT_LAST_COMMIT_DATE }}"
4343
goos:
4444
- linux

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ IMAGE_TAG ?= $(shell ./tools/image-tag)
2323
GIT_REVISION := $(shell git rev-parse --short HEAD)
2424
GIT_BRANCH := $(shell git rev-parse --abbrev-ref HEAD)
2525
GIT_LAST_COMMIT_DATE := $(shell git log -1 --date=iso-strict --format=%cd)
26-
GORELEASER_ENV := GIT_BRANCH=$(GIT_BRANCH) GIT_REVISION=$(GIT_REVISION) GIT_LAST_COMMIT_DATE=$(GIT_LAST_COMMIT_DATE) IMAGE_TAG=$(IMAGE_TAG)
26+
GORELEASER_ENV := GIT_LAST_COMMIT_DATE=$(GIT_LAST_COMMIT_DATE)
2727

2828
# Build flags
2929
VPREFIX := github.com/grafana/phlare/pkg/util/build

0 commit comments

Comments
 (0)