Fix NdrCString not accepting strings in python3 #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

hakril wants to merge 1 commit into master from ndr_string_fix

Owner

hakril commented Oct 15, 2025

Fix #84

Windows does seems to accept any bitstream that ends with \x00 for an FC_C_CSTRING.
But for now, NdrCString use ascii encoding to be sure that encoding keep the same number of bytes that the input string.

I could also accept bytes() (and would apply no modification) to allow the user to send whatever it wants.
Same for NdrWString


          Fix NdrCString not accepting strings in python3

19da4ad

github-actions bot commented Oct 15, 2025 •

edited

Loading

PyTest Results for 3.11-64

520 tests ±0 460 ✅ - 4 2m 36s ⏱️ +7s
1 suites ±0 56 💤 ±0
1 files ±0 4 ❌ +4

For more details on these failures, see this check.

Results for commit 19da4ad. ± Comparison against base commit c46f086.

♻️ This comment has been updated with latest results.

github-actions bot commented Oct 15, 2025 •

edited

Loading

PyTest Results for 2.7-32

520 tests ±0 486 ✅ - 4 2m 50s ⏱️ -35s
1 suites ±0 30 💤 ±0
1 files ±0 4 ❌ +4

For more details on these failures, see this check.

Results for commit 19da4ad. ± Comparison against base commit c46f086.

♻️ This comment has been updated with latest results.

github-actions bot commented Oct 15, 2025

PyTest Results for 3.11-32

520 tests ±0 442 ✅ ±0 2m 49s ⏱️ +13s
1 suites ±0 78 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 19da4ad. ± Comparison against base commit c46f086.

github-actions bot commented Oct 15, 2025 •

edited

Loading

PyTest Results for 3.6-64

520 tests ±0 508 ✅ - 4 2m 55s ⏱️ +16s
1 suites ±0 8 💤 ±0
1 files ±0 4 ❌ +4

For more details on these failures, see this check.

Results for commit 19da4ad. ± Comparison against base commit c46f086.

♻️ This comment has been updated with latest results.

github-actions bot commented Oct 15, 2025 •

edited

Loading

PyTest Results for 3.11-32

520 tests ±0 438 ✅ - 4 3m 31s ⏱️ +55s
1 suites ±0 78 💤 ±0
1 files ±0 4 ❌ +4

For more details on these failures, see this check.

Results for commit 19da4ad. ± Comparison against base commit c46f086.

♻️ This comment has been updated with latest results.

github-actions bot commented Oct 15, 2025 •

edited

Loading

PyTest Results for 2.7-64

520 tests ±0 508 ✅ - 4 2m 38s ⏱️ -11s
1 suites ±0 8 💤 ±0
1 files ±0 4 ❌ +4

For more details on these failures, see this check.

Results for commit 19da4ad. ± Comparison against base commit c46f086.

♻️ This comment has been updated with latest results.

github-actions bot commented Oct 15, 2025 •

edited

Loading

PyTest Results for 3.6-32

520 tests ±0 486 ✅ - 4 3m 11s ⏱️ -1s
1 suites ±0 30 💤 ±0
1 files ±0 4 ❌ +4

For more details on these failures, see this check.

Results for commit 19da4ad. ± Comparison against base commit c46f086.

♻️ This comment has been updated with latest results.

hakril mentioned this pull request

Add tests for NdrCString & NdrWString packing #86

Merged

Owner Author

hakril commented Oct 15, 2025

Superseed by #86

hakril closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet