Skip to content

testing: makes acctest.CheckVPCExists VCR-friendly #45286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gdavison merged 7 commits into from
Dec 2, 2025
Merged

testing: makes acctest.CheckVPCExists VCR-friendly #45286

gdavison merged 7 commits into from
Dec 2, 2025

Conversation

@gdavison
Copy link
Contributor

@gdavison gdavison commented Nov 26, 2025 •
edited by jar-b
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Makes acctest.CheckVPCExists VCR-friendly by adding *testing.T parameter

Relates #25602

@gdavison gdavison requested a review from a team as a code owner November 26, 2025 20:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. service/vpnsite Issues and PRs that pertain to the vpnsite service. service/networkmonitor Issues and PRs that pertain to the networkmonitor service. size/XL Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 26, 2025
ewbankkit
ewbankkit previously approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Base automatically changed from td-factor-out-subnet-config to main December 2, 2025 00:36
@gdavison gdavison dismissed ewbankkit’s stale review December 2, 2025 00:36

The base branch was changed.

@gdavison
Merge pull request #45291 from hashicorp/td-internal-retry-in-generat…
120c4c3 
…ed-code

code generation: Replace `github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry` with `github.com/hashicorp/terraform-provider-aws/internal/retry`
@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/kms Issues and PRs that pertain to the kms service. tags Pertains to resource tagging. labels Dec 2, 2025
ewbankkit
ewbankkit approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit c9bc560 into main Dec 2, 2025
57 checks passed
@gdavison gdavison deleted the td-vcr-CheckVPCExists branch December 2, 2025 21:44
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.24.0 milestone Dec 2, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

This functionality has been released in v6.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

No one assigned

Labels

generators Relates to code generators. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ecs Issues and PRs that pertain to the ecs service. service/emr Issues and PRs that pertain to the emr service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/kms Issues and PRs that pertain to the kms service. service/networkmonitor Issues and PRs that pertain to the networkmonitor service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

v6.24.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gdavison @ewbankkit