r/aws_billing_view: Fix data_filter_expression handling
#45293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the recently introduced
aws_billing_viewresource (initially added in #45097) wheredata_filter_expressionconfigurations were being silently dropped during creation and update, leading to state inconsistencies.Currently, if a user attempts to configure
data_filter_expression(e.g., filtering by tags or dimensions), the generic flex reflection helpers fail to map the TerraformListNestedBlockto the corresponding AWS SDK struct.This results in two issues:
produces
To fix the issue, this PR introduces manual expansion and flattening logic for the
data_filter_expressionfield.Expansion: Added
expandDataFilterExpressionhelper to manually extract values from the TerraformListNestedBlock(taking the 0th index) and construct the*awstypes.DataFilterExpressionstruct required by the AWS SDK.Flattening: Added
flattenDataFilterExpressionhelper to correctly map the AWS SDK response back into the Terraform state structure.