skip tests that use time.Now in VCR (#13555) (#9731)

modular-magician · web-flow · commit 7f97beb23c50 · 2025-04-04T15:35:40.000-07:00
[upstream:3c558b65bddae36c0cf730f850b0fa4dbf6b8750]

Signed-off-by: Modular Magician &lt;magic-modules@google.com&gt;
diff --git a/google-beta/services/compute/resource_compute_instance_from_machine_image_test.go b/google-beta/services/compute/resource_compute_instance_from_machine_image_test.go
@@ -78,6 +78,8 @@ func TestAccComputeInstanceFromMachineImage_maxRunDuration(t *testing.T) {
 }
 
 func TestAccComputeInstanceFromMachineImage_terminationTime(t *testing.T) {
+	// Uses time.Now
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	var instance compute.Instance
diff --git a/google-beta/services/compute/resource_compute_instance_from_template_test.go b/google-beta/services/compute/resource_compute_instance_from_template_test.go
@@ -399,6 +399,8 @@ func TestAccComputeInstanceFromTemplate_overrideScheduling(t *testing.T) {
 }
 
 func TestAccComputeInstanceFromTemplate_TerminationTime(t *testing.T) {
+	// Uses time.Now
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	var instance compute.Instance
diff --git a/google-beta/services/compute/resource_compute_instance_template_test.go b/google-beta/services/compute/resource_compute_instance_template_test.go
@@ -1415,6 +1415,8 @@ func TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction(t *testi
 }
 
 func TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime(t *testing.T) {
+	// Uses time.Now
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	var instanceTemplate compute.InstanceTemplate
diff --git a/google-beta/services/compute/resource_compute_instance_test.go b/google-beta/services/compute/resource_compute_instance_test.go
@@ -1681,6 +1681,8 @@ func TestAccComputeInstance_scheduling(t *testing.T) {
 }
 
 func TestAccComputeInstance_schedulingTerminationTime(t *testing.T) {
+	// Uses time.Now
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	var instance compute.Instance
diff --git a/google-beta/services/compute/resource_compute_region_instance_template_test.go b/google-beta/services/compute/resource_compute_region_instance_template_test.go
@@ -1249,6 +1249,8 @@ func TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction(t
 }
 
 func TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime(t *testing.T) {
+	// Uses time.Now
+	acctest.SkipIfVcr(t)
 	t.Parallel()
 
 	var instanceTemplate compute.InstanceTemplate

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,8 @@ func TestAccComputeInstanceFromMachineImage_maxRunDuration(t *testing.T) {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`func TestAccComputeInstanceFromMachineImage_terminationTime(t *testing.T) {`
	`81`	`+ // Uses time.Now`
	`82`	`+ acctest.SkipIfVcr(t)`
`81`	`83`	`t.Parallel()`
`82`	`84`
`83`	`85`	`var instance compute.Instance`
Original file line number	Diff line number	Diff line change
`@@ -399,6 +399,8 @@ func TestAccComputeInstanceFromTemplate_overrideScheduling(t *testing.T) {`
`399`	`399`	`}`
`400`	`400`
`401`	`401`	`func TestAccComputeInstanceFromTemplate_TerminationTime(t *testing.T) {`
	`402`	`+ // Uses time.Now`
	`403`	`+ acctest.SkipIfVcr(t)`
`402`	`404`	`t.Parallel()`
`403`	`405`
`404`	`406`	`var instance compute.Instance`
Original file line number	Diff line number	Diff line change
`@@ -1415,6 +1415,8 @@ func TestAccComputeInstanceTemplate_maxRunDuration_onInstanceStopAction(t *testi`
`1415`	`1415`	`}`
`1416`	`1416`
`1417`	`1417`	`func TestAccComputeInstanceTemplate_instanceTerminationAction_terminationTime(t *testing.T) {`
	`1418`	`+ // Uses time.Now`
	`1419`	`+ acctest.SkipIfVcr(t)`
`1418`	`1420`	`t.Parallel()`
`1419`	`1421`
`1420`	`1422`	`var instanceTemplate compute.InstanceTemplate`
Original file line number	Diff line number	Diff line change
`@@ -1681,6 +1681,8 @@ func TestAccComputeInstance_scheduling(t *testing.T) {`
`1681`	`1681`	`}`
`1682`	`1682`
`1683`	`1683`	`func TestAccComputeInstance_schedulingTerminationTime(t *testing.T) {`
	`1684`	`+ // Uses time.Now`
	`1685`	`+ acctest.SkipIfVcr(t)`
`1684`	`1686`	`t.Parallel()`
`1685`	`1687`
`1686`	`1688`	`var instance compute.Instance`
Original file line number	Diff line number	Diff line change
`@@ -1249,6 +1249,8 @@ func TestAccComputeRegionInstanceTemplate_maxRunDuration_onInstanceStopAction(t`
`1249`	`1249`	`}`
`1250`	`1250`
`1251`	`1251`	`func TestAccComputeRegionInstanceTemplate_instanceTerminationAction_terminationTime(t *testing.T) {`
	`1252`	`+ // Uses time.Now`
	`1253`	`+ acctest.SkipIfVcr(t)`
`1252`	`1254`	`t.Parallel()`
`1253`	`1255`
`1254`	`1256`	`var instanceTemplate compute.InstanceTemplate`