Documentation changes to include "disk" resource type in backup_dr (#13922) (#10159)

[upstream:e29e37ce2360cae0b7cdc0cca3c0863ead6265f5]

Signed-off-by: Modular Magician <magic-modules@google.com>

Author: modular-magician

google-beta/services/backupdr/resource_backup_dr_backup_plan.go

@@ -206,10 +206,11 @@ This is required for 'recurrence_type', 'HOURLY' and is not applicable otherwise
 				Description: `The location for the backup plan`,
 			},
 			"resource_type": {
-				Type:        schema.TypeString,
-				Required:    true,
-				ForceNew:    true,
-				Description: `The resource type to which the 'BackupPlan' will be applied. Examples include, "compute.googleapis.com/Instance" and "storage.googleapis.com/Bucket".`,
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+				Description: `The resource type to which the 'BackupPlan' will be applied.
+Examples include, "compute.googleapis.com/Instance", "compute.googleapis.com/Disk", and "storage.googleapis.com/Bucket".`,
 			},
 			"description": {
 				Type:        schema.TypeString,

google-beta/services/backupdr/resource_backup_dr_backup_plan_association.go

@@ -58,7 +58,10 @@ func ResourceBackupDRBackupPlanAssociation() *schema.Resource {
 				Required:         true,
 				ForceNew:         true,
 				DiffSuppressFunc: tpgresource.ProjectNumberDiffSuppress,
-				Description:      `The BP with which resource needs to be created`,
+				Description: `The BP with which resource needs to be created
+Note:
+- A Backup Plan configured for 'compute.googleapis.com/Instance', can only protect instance type resources.
+- A Backup Plan configured for 'compute.googleapis.com/Disk' can be used to protect both standard Disks and Regional Disks resources.`,
 			},
 			"backup_plan_association_id": {
 				Type:        schema.TypeString,
@@ -79,10 +82,11 @@ func ResourceBackupDRBackupPlanAssociation() *schema.Resource {
 				Description: `The resource for which BPA needs to be created`,
 			},
 			"resource_type": {
-				Type:        schema.TypeString,
-				Required:    true,
-				ForceNew:    true,
-				Description: `The resource type of workload on which backupplan is applied`,
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+				Description: `The resource type of workload on which backupplan is applied.
+Examples include, "compute.googleapis.com/Instance", "compute.googleapis.com/Disk", and "compute.googleapis.com/RegionDisk"`,
 			},
 			"create_time": {
 				Type:        schema.TypeString,

google-beta/services/backupdr/resource_backup_dr_backup_plan_generated_test.go

@@ -88,6 +88,66 @@ resource "google_backup_dr_backup_plan" "my-backup-plan-1" {
 `, context)
 }
 
+func TestAccBackupDRBackupPlan_backupDrBackupPlanForDiskResourceExample(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
+		CheckDestroy:             testAccCheckBackupDRBackupPlanDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccBackupDRBackupPlan_backupDrBackupPlanForDiskResourceExample(context),
+			},
+			{
+				ResourceName:            "google_backup_dr_backup_plan.my-disk-backup-plan-1",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"backup_plan_id", "location"},
+			},
+		},
+	})
+}
+
+func testAccBackupDRBackupPlan_backupDrBackupPlanForDiskResourceExample(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_backup_dr_backup_vault" "my_backup_vault" {
+  provider = google-beta
+  location                                      = "us-central1"
+  backup_vault_id                               = "tf-test-backup-vault-disk-test%{random_suffix}"
+  backup_minimum_enforced_retention_duration    = "100000s"
+}
+
+resource "google_backup_dr_backup_plan" "my-disk-backup-plan-1" {
+  provider       = google-beta
+  location       = "us-central1"
+  backup_plan_id = "tf-test-backup-plan-disk-test%{random_suffix}"
+  resource_type  = "compute.googleapis.com/Disk"
+  backup_vault   = google_backup_dr_backup_vault.my_backup_vault.id
+
+  backup_rules {
+    rule_id                = "rule-1"
+    backup_retention_days  = 5
+
+    standard_schedule {
+      recurrence_type     = "HOURLY"
+      hourly_frequency    = 1
+      time_zone           = "UTC"
+
+      backup_window {
+        start_hour_of_day = 0
+        end_hour_of_day   = 6
+      }
+    }
+  }
+}
+`, context)
+}
+
 func testAccCheckBackupDRBackupPlanDestroyProducer(t *testing.T) func(s *terraform.State) error {
 	return func(s *terraform.State) error {
 		for name, rs := range s.RootModule().Resources {

website/docs/r/backup_dr_backup_plan.html.markdown

@@ -63,6 +63,41 @@ resource "google_backup_dr_backup_plan" "my-backup-plan-1" {
   }
 }
 ```
+## Example Usage - Backup Dr Backup Plan For Disk Resource
+
+
+```hcl
+resource "google_backup_dr_backup_vault" "my_backup_vault" {
+  provider = google-beta
+  location                                      = "us-central1"
+  backup_vault_id                               = "backup-vault-disk-test"
+  backup_minimum_enforced_retention_duration    = "100000s"
+}
+
+resource "google_backup_dr_backup_plan" "my-disk-backup-plan-1" {
+  provider       = google-beta
+  location       = "us-central1"
+  backup_plan_id = "backup-plan-disk-test"
+  resource_type  = "compute.googleapis.com/Disk"
+  backup_vault   = google_backup_dr_backup_vault.my_backup_vault.id
+
+  backup_rules {
+    rule_id                = "rule-1"
+    backup_retention_days  = 5
+
+    standard_schedule {
+      recurrence_type     = "HOURLY"
+      hourly_frequency    = 1
+      time_zone           = "UTC"
+
+      backup_window {
+        start_hour_of_day = 0
+        end_hour_of_day   = 6
+      }
+    }
+  }
+}
+```
 
 ## Argument Reference
 
@@ -75,7 +110,8 @@ The following arguments are supported:
 
 * `resource_type` -
   (Required)
-  The resource type to which the `BackupPlan` will be applied. Examples include, "compute.googleapis.com/Instance" and "storage.googleapis.com/Bucket".
+  The resource type to which the `BackupPlan` will be applied.
+  Examples include, "compute.googleapis.com/Instance", "compute.googleapis.com/Disk", and "storage.googleapis.com/Bucket".
 
 * `backup_rules` -
   (Required)

website/docs/r/backup_dr_backup_plan_association.html.markdown

@@ -117,10 +117,14 @@ The following arguments are supported:
 * `backup_plan` -
   (Required)
   The BP with which resource needs to be created
+  Note:
+  - A Backup Plan configured for 'compute.googleapis.com/Instance', can only protect instance type resources.
+  - A Backup Plan configured for 'compute.googleapis.com/Disk' can be used to protect both standard Disks and Regional Disks resources.
 
 * `resource_type` -
   (Required)
-  The resource type of workload on which backupplan is applied
+  The resource type of workload on which backupplan is applied.
+  Examples include, "compute.googleapis.com/Instance", "compute.googleapis.com/Disk", and "compute.googleapis.com/RegionDisk"
 
 * `location` -
   (Required)