Skip to content

Commit 989522d

Browse files
Fix TestAccDataSourceGoogleGkeHubFeature_basic (#15789) (#11138)
[upstream:b117259c0d893d0e223efa7e7ac2448e40b3e893] Signed-off-by: Modular Magician <magic-modules@google.com>
1 parent 82b7d1d commit 989522d

File tree

2 files changed

+80
-120
lines changed

2 files changed

+80
-120
lines changed

google-beta/services/gkehub2/data_source_google_gke_hub_feature_test.go

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
2525
"github.com/hashicorp/terraform-plugin-testing/terraform"
2626
"github.com/hashicorp/terraform-provider-google-beta/google-beta/acctest"
27+
"github.com/hashicorp/terraform-provider-google-beta/google-beta/envvar"
2728
"github.com/hashicorp/terraform-provider-google-beta/google-beta/tpgresource"
2829
transport_tpg "github.com/hashicorp/terraform-provider-google-beta/google-beta/transport"
2930
)
@@ -32,13 +33,18 @@ func TestAccDataSourceGoogleGkeHubFeature_basic(t *testing.T) {
3233
t.Parallel()
3334

3435
context := map[string]interface{}{
35-
"random_suffix": acctest.RandString(t, 10),
36+
"random_suffix": acctest.RandString(t, 10),
37+
"org_id": envvar.GetTestOrgFromEnv(t),
38+
"billing_account": envvar.GetTestBillingAccountFromEnv(t),
3639
}
3740

3841
acctest.VcrTest(t, resource.TestCase{
3942
PreCheck: func() { acctest.AccTestPreCheck(t) },
4043
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
41-
CheckDestroy: testAccCheckGoogleGkeHubFeatureDestroyProducer(t),
44+
ExternalProviders: map[string]resource.ExternalProvider{
45+
"time": {},
46+
},
47+
CheckDestroy: testAccCheckGoogleGkeHubFeatureDestroyProducer(t),
4248
Steps: []resource.TestStep{
4349
{
4450
Config: testAccDataSourceGoogleGkeHubFeature_basic(context),
@@ -51,15 +57,18 @@ func TestAccDataSourceGoogleGkeHubFeature_basic(t *testing.T) {
5157
}
5258

5359
func testAccDataSourceGoogleGkeHubFeature_basic(context map[string]interface{}) string {
54-
return acctest.Nprintf(`
60+
return gkeHubFeatureProjectSetupForGA(context) + acctest.Nprintf(`
5561
resource "google_gke_hub_feature" "example" {
56-
location = "global"
57-
name = "servicemesh"
62+
location = "global"
63+
name = "servicemesh"
64+
depends_on = [time_sleep.wait_for_gkehub_enablement]
65+
project = google_project.project.project_id
5866
}
5967
6068
data "google_gke_hub_feature" "example" {
6169
location = google_gke_hub_feature.example.location
6270
name = google_gke_hub_feature.example.name
71+
project = google_project.project.project_id
6372
}
6473
`, context)
6574
}

0 commit comments

Comments
 (0)