Refactor comments for clarity and update rule usage in needsCompilationRule

Author: soulomoon

ghcide/src/Development/IDE/Core/RuleTypes.hs

@@ -74,7 +74,7 @@ type instance RuleResult GetParsedModuleWithComments = ParsedModule
 
 type instance RuleResult GetModuleGraph = DependencyInformation
 
--- same as DependencyInformation but only rebuilds if the target file deps changes
+-- same as GetModuleGraph but only rebuilds if the target file deps changes
 type instance RuleResult GetFileModuleGraph = DependencyInformation
 
 data GetKnownTargets = GetKnownTargets

ghcide/src/Development/IDE/Core/Rules.hs

@@ -1145,7 +1145,7 @@ needsCompilationRule file
   | "boot" `isSuffixOf` fromNormalizedFilePath file =
     pure (Just $ encodeLinkableType Nothing, Just Nothing)
 needsCompilationRule file = do
-  graph <- useNoFile GetModuleGraph
+  graph <- use GetFileModuleGraph file
   res <- case graph of
     -- Treat as False if some reverse dependency header fails to parse
     Nothing -> pure Nothing

ghcide/src/Development/IDE/Import/DependencyInformation.hs

@@ -411,8 +411,8 @@ instance NFData NamedModuleDep where
 instance Show NamedModuleDep where
   show NamedModuleDep{..} = show nmdFilePath
 
--- | Build a map from file path to fingerprint. The fingerprint is built
--- from the fingerprints of the file and all its dependencies.
+-- | Build a map from file path to its full fingerprint.
+-- The fingerprint is depend on both the fingerprints of the file and all its dependencies.
 -- This is used to determine if a file has changed and needs to be reloaded.
 buildAccFingerFilePathIdMap :: FilePathIdMap FilePathIdSet -> FilePathIdMap Fingerprint -> FilePathIdMap Fingerprint
 buildAccFingerFilePathIdMap modulesDeps shallowFingers = go keys IntMap.empty